[PATCHv4,4/8] Convert _Complex sine functions to generated code
diff mbox

Message ID 85040f0b-9bb6-2d0b-dd15-8435fca72a33@linux.vnet.ibm.com
State New
Headers show

Commit Message

Paul E. Murphy Aug. 19, 2016, 7:23 p.m. UTC
On 08/19/2016 12:28 PM, Joseph Myers wrote:
> On Thu, 18 Aug 2016, Paul E. Murphy wrote:
> 
>> +	      __real__ res = M_LOG1P (rx2 + dm + 2
>> +				      * (rx * r1 + ix * r2)) / 2;
> 
> I don't like this choice of position for a line break, since the '*' at 
> the start of the second line only applies to the 2 on the line above, not 
> to the whole of "rx2 + dm + 2" which the split makes it look like it 
> should apply to.
> 
> Patches 3 and 4 are OK with that fixed (for example, to have the second 
> line start "+ 2 * (rx...").  The same comments as before apply about scope 
> for m68k maintainers to make further cleanups.
> 

Looking closer, the break is not needed. It fits in 78 columns.  Pending no
objection, I will commit with the following change:

Comments

Joseph Myers Aug. 19, 2016, 8:05 p.m. UTC | #1
On Fri, 19 Aug 2016, Paul E. Murphy wrote:

> Looking closer, the break is not needed. It fits in 78 columns.  Pending no
> objection, I will commit with the following change:

That version is fine.
Paul E. Murphy Aug. 19, 2016, 9:52 p.m. UTC | #2
On 08/19/2016 03:05 PM, Joseph Myers wrote:
> On Fri, 19 Aug 2016, Paul E. Murphy wrote:
> 
>> Looking closer, the break is not needed. It fits in 78 columns.  Pending no
>> objection, I will commit with the following change:
> 
> That version is fine.


Committed with the fixed comments as ffb84f5 and c50eee1.

Patch
diff mbox

diff --git a/math/k_casinh_template.c b/math/k_casinh_template.c
index 0b29e6a..74626b1 100644
--- a/math/k_casinh_template.c
+++ b/math/k_casinh_template.c
@@ -157,8 +157,7 @@  M_DECL_FUNC (__kernel_casinh) (CFLOAT x, int adj)
              FLOAT r1 = M_SQRT ((dp + rx2) / 2);
              FLOAT r2 = rx * ix / r1;
 
-             __real__ res = M_LOG1P (rx2 + dm + 2
-                                     * (rx * r1 + ix * r2)) / 2;
+             __real__ res = M_LOG1P (rx2 + dm + 2 * (rx * r1 + ix * r2)) / 2;
              if (adj)
                __imag__ res = M_ATAN2 (rx + r1, M_COPYSIGN (ix + r2,
                                                             __imag__ x));