diff mbox

[U-Boot] net/fm: Remove unused code of FMan QMI

Message ID 1471577735-21742-1-git-send-email-Zhiqiang.Hou@nxp.com
State Accepted
Commit c23c7d461fc52f03f784dee9792f8547d14e731d
Delegated to: Joe Hershberger
Headers show

Commit Message

Z.Q. Hou Aug. 19, 2016, 3:35 a.m. UTC 
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

The QMan is not used in FMan IM mode, so no QMI enqueue or QMI
dequeue are performed.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
 drivers/net/fm/fm.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Joe Hershberger Aug. 19, 2016, 6:52 p.m. UTC | #1 
On Thu, Aug 18, 2016 at 10:35 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> The QMan is not used in FMan IM mode, so no QMI enqueue or QMI
> dequeue are performed.
>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

Seems reasonable.

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Joe Hershberger Aug. 23, 2016, 2:28 a.m. UTC | #2 
Hi Zhiqiang,

https://patchwork.ozlabs.org/patch/660698/ was applied to u-boot-net.git.

Thanks!
-Joe
diff mbox

Patch

diff --git a/drivers/net/fm/fm.c b/drivers/net/fm/fm.c
index 00cdfd4..5eb773e 100644
--- a/drivers/net/fm/fm.c
+++ b/drivers/net/fm/fm.c
@@ -336,9 +336,6 @@  static int fm_init_bmi(int fm_idx, struct fm_bmi_common *bmi)
 
 static void fm_init_qmi(struct fm_qmi_common *qmi)
 {
-	/* disable enqueue and dequeue of QMI */
-	clrbits_be32(&qmi->fmqm_gc, FMQM_GC_ENQ_EN | FMQM_GC_DEQ_EN);
-
 	/* disable all error interrupts */
 	out_be32(&qmi->fmqm_eien, FMQM_EIEN_DISABLE_ALL);
 	/* clear all error events */