diff mbox

[net] sit: ipip6_valid_ip_proto() is static

Message ID 1471539835.29842.72.camel@edumazet-glaptop3.roam.corp.google.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Eric Dumazet Aug. 18, 2016, 5:03 p.m. UTC 
From: Eric Dumazet <edumazet@google.com>

Fixes this sparse error :
net/ipv6/sit.c:1129:6: warning: symbol 'ipip6_valid_ip_proto' was not
declared. Should it be static?


Fixes: 49dbe7ae2168b ("sit: support MPLS over IPv4")
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/ipv6/sit.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Aug. 20, 2016, 12:08 a.m. UTC | #1 
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 18 Aug 2016 10:03:55 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> Fixes this sparse error :
> net/ipv6/sit.c:1129:6: warning: symbol 'ipip6_valid_ip_proto' was not
> declared. Should it be static?
> 
> 
> Fixes: 49dbe7ae2168b ("sit: support MPLS over IPv4")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

This was done in net-next already.
diff mbox

Patch

diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 182b6a9be29d..d6da9febb12d 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -1126,7 +1126,7 @@  static int ipip6_tunnel_update_6rd(struct ip_tunnel *t,
 }
 #endif
 
-bool ipip6_valid_ip_proto(u8 ipproto)
+static bool ipip6_valid_ip_proto(u8 ipproto)
 {
 	return ipproto == IPPROTO_IPV6 ||
 		ipproto == IPPROTO_IPIP ||