Message ID | 1471570860-2087-3-git-send-email-Nitin.Chaudhary@zii.aero |
---|---|
State | New |
Headers | show
Return-Path: <linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sFm2s4fyhz9t2N for <incoming-imx@patchwork.ozlabs.org>; Fri, 19 Aug 2016 11:43:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=zodiacii.onmicrosoft.com header.i=@zodiacii.onmicrosoft.com header.b=lX/u1+8n; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1baYp9-0004Go-GZ; Fri, 19 Aug 2016 01:42:19 +0000 Received: from mail-cys01nam02on0079.outbound.protection.outlook.com ([104.47.37.79] helo=NAM02-CY1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1baYoY-00044l-N5 for linux-arm-kernel@lists.infradead.org; Fri, 19 Aug 2016 01:41:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zodiacii.onmicrosoft.com; s=selector1-zii-aero; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7eJntSj9C6yc0kbUORFVhFy1eIvw6t4ot1SLKnxqKGA=; b=lX/u1+8nL7J7vif6hYaVUlN5RyM7tPcov9EJkkZCNq0Ebq6Q0kE39dwnQ+DjYA1b+it/3luRLZml5Xf2mXqkUqu5PVsn9EeGmmZ3C8wSzfGJl4QBRa9flyRi3ZJEkC6oUkPpTMYomC6tWP0CH/AieWI/8sYA3fi+44+PWCw0+i0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Nitin.Chaudhary@zii.aero; Received: from nitinc-Latitude-E6540.ims.dom (64.60.156.46) by CY1PR12MB0551.namprd12.prod.outlook.com (10.161.172.156) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.21; Fri, 19 Aug 2016 01:41:16 +0000 From: Nitin Chaudhary <Nitin.Chaudhary@zii.aero> To: <zhengyu.shen@nxp.com> Subject: [PATCH 2/3] [i.MX6Q] Code cleanup & verification after fixing compilation error Date: Thu, 18 Aug 2016 18:40:59 -0700 Message-ID: <1471570860-2087-3-git-send-email-Nitin.Chaudhary@zii.aero> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1471570860-2087-1-git-send-email-Nitin.Chaudhary@zii.aero> References: <DB5PR04MB1430487C8BFA276E285493959F150@DB5PR04MB1430.eurprd04.prod.outlook.com> <1471570860-2087-1-git-send-email-Nitin.Chaudhary@zii.aero> MIME-Version: 1.0 X-Originating-IP: [64.60.156.46] X-ClientProxiedBy: CO2PR11CA0038.namprd11.prod.outlook.com (10.141.242.176) To CY1PR12MB0551.namprd12.prod.outlook.com (10.161.172.156) X-MS-Office365-Filtering-Correlation-Id: 5f426a76-574f-47b8-c8ef-08d3c7d1e9c3 X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0551; 2:TZKlv+zGNxnPG1h5Fu6FMjOKQq+T9AaCuXYiTfzTqKL6nmAUEV5tPKFxAcXMpr6OJnni2jV2VQlREj1CPy5oTcqqjFFBEU5O+fwWAZoTdleBdqNrZxyC/bwWli/VFJjOMj4nZ9bZlBqZ+H8lNyKqVtg3tBLzV2Tbxpp7jnWp4lrL2nEp1yllPCxy2TNHRBtV; 3:gdlXhBY0ZTR3zS8G8P5qaIAGdYLWm6jQYtQ4jOiuh8Tq+9kxDLpc8AufYgoUt/vsFml38Z5yoEau0pTfhtYYafarDd05Efe7/YqxloQI++tentqTQMAchVoTAOJIpQa+; 25:RFV6np5DEicR46FvbIqt1qGvDnKGuyBdf2zvr3TxxeOHrLIrdvqY0P5b7m28aJw2m3iNSsJChKFWa0lAKOSHywiK325UrAOLNjeJkmLcS2CqWpeRLHcpIJQF+Y6gbPFGA3nkDc8POvDndPnzz0afTT0hqqUoTH1FoeJyQkHP+K8V5GkhKwfGVOqJPvvR5Sagw8SWskxO9wd574zquledYm7xDsloRvFOuRJbT6X71wLhnVxHUdpHuEWrVUJBejfYlHFqPLXUxLelbx67+vVHzsVZ3Do4W1y8nhdtp3/2+IQXsTZf3Iy6oeo94iJg6Gxuz6bW5F4xMiaFtDPfLNsWlPh9XYv4vs7O/pW6VzN9KgP5rXdjy30SuUorR9qj35pulySVdXMSEhRnRnA+sHlEdt4OYwQk11egZEbmhUYPQ9g= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0551; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0551; 31:yyfjrArdzTZKGGL3cHdExe4407GJv7yViSwunKfeZWi7GlOovYF1x9cxHi8fcxHmOqw2N6sLTf+IPtGR9Tq3T68UTk7ChxQdtRyTFCx8HyXH+bcwQcBbpv+e4aAbPxliIqDKJcesxKDIX9ZP+zN9U+so+OZNt8wVnYyb8ddKS0wyZSupDX4+4J5Z+1dOV98E13nc6kbHh7dY+/it+HtaGlZd1b48shDnEtZi/0pNlyo=; 20:OulMlgrA9FDD2wekxBUNvelseiM5QnoM9uY6KmhYOatzoJVBU0DY66BELRu2ZGLvNs5rdyUF/WopRIAx9j0rKdnEsy5zq7xozrlPaBtbKY4a3GhGrAQ0wllexJSOkhMsgHHCv7Uypcd8x01VWIc6eHKCJ1ALNPHQ7vUwfeIQMYo=; 4:oy/XVjhezx6eDjeoGhEV6M02qze6jZnrz2NfRtdmyUnGeynoFnvLO1/x8bAwfU7YTQ+/Y5LzTv+0yujkaJzZyyVytiTdW6g6tALAqMlpN/YCT7yv8nWq9qikJs9+jLHIsw3bMatFmEz0nHvRwp8oBELmGgOhTiZQa+AIAFaPZqUoJmGNEDbw8SZqVHPLM30qzkDTC8aXKyj8nVMHIqi1i6Erhv3OAZ6R7xgcaCXAaJmO6ZnG5wwZZcS4zdpxmu8SVgkf6SeiFIcChslA1h3IsAUp9PEz6uObrvpf7RXOAaiwptcKEnRO+Wk4HhY9QUu4rRsAfjEA4pRBJfpvSQTX5qIiUCSYfDBALqY7x9kQj8QeRRxgl8JLf2nCihTLV92LImhawBow+5Ml05Q+yNJ1KcorNIXB15Pdj8JhRkFIVpg= X-Microsoft-Antispam-PRVS: <CY1PR12MB0551BED50DA98738E89E2FC194160@CY1PR12MB0551.namprd12.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6042046)(6043046); SRVR:CY1PR12MB0551; BCL:0; PCL:0; RULEID:; SRVR:CY1PR12MB0551; X-Forefront-PRVS: 0039C6E5C5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(40124003)(50226002)(68736007)(19580395003)(36756003)(7736002)(2950100001)(586003)(86362001)(8746002)(19580405001)(8666005)(101416001)(7846002)(6116002)(2351001)(77096005)(97736004)(3846002)(110136002)(92566002)(47776003)(4326007)(66066001)(50986999)(105586002)(53416004)(189998001)(76176999)(50466002)(2906002)(42186005)(106356001)(229853001)(305945005)(81166006)(48376002)(5003940100001)(81156014)(8676002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0551; H:nitinc-Latitude-E6540.ims.dom; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:0; LANG:en; Received-SPF: None (protection.outlook.com: zii.aero does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR12MB0551; 23:t2K3yOXNP4lzje2lpvT7R7rb+GggHiUNla6/GK8XB?= =?us-ascii?Q?XC7SiiwPB+VC9F0Rbr1mF7c7lWenmJ7buRaPlTbbSlFzgYdavh2rPg68ch/4?= =?us-ascii?Q?zF2gV5lPu/dmOquh+941nJVvP/PclO4CE/7rZuGlejq4lZhoobsBy17liluG?= =?us-ascii?Q?uGrNR6d3GedR93bzCFhT9RkzbfxuaZWQIlLZ4oSwXaLpXArtWpF83RPyZvQW?= =?us-ascii?Q?rVxlTkSJwi040TJzl0OPgud71B4Bfk8hvZrb4h3F26BRzQ0PR5/ukjV23FDR?= =?us-ascii?Q?6S5q3EsYti7Iv7PDtHmH9Lx05SOYrxCO48FD4AT1A0NERH7+YQRx8Uo9Dvwx?= =?us-ascii?Q?Kcjy75yTIgdHami0sathT77+lcF74Ngp7ZzkHBoh9q0LcJtjm0lQ+6Y7iP4k?= =?us-ascii?Q?Mmnto+AQQEjJjU3bLEPUq1femJuY06wd7t4r7gVN3iiuSAhqwaqCYts/lVOU?= =?us-ascii?Q?eqkGG8tbIW51BgBKTdcCZKaCUyWFb8JaqmHv7BiE6QyCBtsTWPgwRaZbGxXH?= =?us-ascii?Q?eOxykl49kqKIzu3m6MMD09Div/QuBLxVYdZ4KgXjqQ/WXgvoyjEhlds9CYnV?= =?us-ascii?Q?srmmoJoCiEBOCUSVmUUzyhJS8yBJd7VSdTVIfalAtxrbYg5Be/dh+GVSWW9+?= =?us-ascii?Q?7Jf15VPHfcERJcxhTYqpvYxcx+eo1oQ8tTU4SQbfcsvZegrHTFKt9oRMvRlm?= =?us-ascii?Q?hJZjRDpnTKWSMa2T9sO3dxdQL38j8DuJfVrJB1AWSaYmAD9rllXXDEVD+qZp?= =?us-ascii?Q?lVg3UF0YRPojeSJrilKU4GSc2NOh0izdlROQ0LVPQL8FGO0Opcz3bKGKhkK6?= =?us-ascii?Q?AQAntVu5pnbOlSOhuhn801fW7NtlDGTit/+sWRnBnm9U2Esrs4xTlWgpSvd+?= =?us-ascii?Q?tf9NYoKEsH6iPvEfnL91KdNakC0witt6oS4G3XGEQ1zocavSY/ycKRCsfItm?= =?us-ascii?Q?SI1AbN0My/7SHiGifu8Jh8RxvsJCbtqaeDugTzDhXmlZ1cJZ0Ux2ZaJek5tX?= =?us-ascii?Q?b3Vdaaop+b94hp8KO1sqGshuw48/xEKRVZxBU3bbCU8JSpRtKYzsIN4h5Jvp?= =?us-ascii?Q?bt8yqrdwoZv0oiH0Sfz3D1NIw+e4mYIyeqz/zqnkk3MzeoubIo7bdOqpbHzz?= =?us-ascii?Q?ZWtE9EqWfvSuO5oGFeuw5G0gsybiwcL?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0551; 6:FCYECIUBSWeS1ZdR81mjRX/pm5ZiMhFsBtP1DqVqfYShv56VXi5tZoirVNKR150mPgCNgSUi9oOjz5tHQe9ZgO+Cpa17iiH/FVM5CYBakFzmLONCEpeHHkV7XvXSPnnE0z6w4CTbG7jGqbFUxtqBoxHGbvqYA7wE++04kGtMj1DkbqvI7+EjnQb6cWRxoNzhl7We79XuIKgASTk7k9uyA1wcr4MkUZOUelfxCarx5Wi0WQnuX6/1nKbdP1AwtV9ZpuXt4nVBcAa984Hapx0YVtFkQiPs5pOJWdoCVMqeuYxQnRkqzHAvOJECPIqvRf9b; 5:R8jRI5lQC6/lqrX0sOSxcdYZkBGlM+L+hvMbKbOsmgH8QiXnUJHGua1O0UnE0H29ayaINzQ6YYInNDpQazlNvTLRFeuzeZG83s/MK49EY6R6EzRjAq0ClKj9g/NkVa1K9C7xw2GSDEgA1p/XtekzSQ==; 24:F1G4c7POZ8c45uZzlnh5TGYt7Hda8LIfvsNrJARCGXhS/xaFGSj25xFi1FECvE3MJbIlcfNsYNlU4YQBFyLB9Tz9nhkokvj5gBSGMhKH7mc=; 7:oiYddym4XPSyBDOHZ/+07hGmw93Qcm+Nz7HYIbq/YDN0OYWf4UdbMir+vxhMpYWmjPjUGf/Oh2dMZhTlaBRCtQq3eukizKD6vid3fXjMcbgBlAfxIaGdA3gUe0PPh2GRJYSb4qH8P/BlH3NWDxr31S8Ysop39FZdwcPGBbka8tyJO33RkOfPMh/INrLpQzD2SsyL7eyq/tB+jrHvNFRvtCsso/3kfFdDvu7RD/tWa7EPzVyBr2S8y7yWWGMA1GNN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: zii.aero X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2016 01:41:16.7932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0551 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160818_184142_906443_80FD4AF4 X-CRM114-Status: GOOD ( 13.10 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [104.47.37.79 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [104.47.37.79 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Nitin Chaudhary <Nitin.Chaudhary@zii.aero>, nitinchaudhary1289@gmail.com, cphealy@gmail.com, linux-arm-kernel@lists.infradead.org, Chris.Healy@zii.aero Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org |
diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c index 95c222d..45790f5 100644 --- a/arch/arm/mach-imx/mmdc.c +++ b/arch/arm/mach-imx/mmdc.c @@ -204,9 +204,10 @@ static int mmdc_cpu_offline(unsigned int cpu) perf_pmu_migrate_context(&pmu_ptr->pmu, cpu, target); cpumask_set_cpu(target, &pmu_ptr->cpu); - /* - if(pmu_ptr->irq) - WARN_ON(irq_set_affinity_hint(pmu_ptr->irq, &pmu_ptr->cpu) != 0); + /* + * TODO: Need to check if we need it or not + * if(pmu_ptr->irq) + * WARN_ON(irq_set_affinity_hint(pmu_ptr->irq, &pmu_ptr->cpu) != 0); */ return 0; } @@ -374,7 +375,12 @@ static int imx_mmdc_probe(struct platform_device *pdev) if (unlikely(!timeout)) { pr_warn("%s: failed to enable automatic power saving\n", __func__); - //return -EBUSY; + + /* + * TODO: Need to check why Automatic Power saving is not + * getting enabled successfully. + * return -EBUSY; + */ } pmu_mmdc = kzalloc(sizeof(*pmu_mmdc), GFP_KERNEL);
Cleanup the code after fixing build error in Zhengyu Shen's perf mmdc integrated driver. The error occured due to migration of CPU Hotplug notifiers to a state machine based mechanism. Made the necessary cha- nges into the code and tested the same on an i.MX6QP FSL Board. The changes allow clean compilation and work fine as well. The results are as follows: root@RDU2:~ perf stat -a -e mmdc/busy-cycles/,mmdc/read-accesses/,mmdc/read-byte s/,mmdc/total-cycles/,mmdc/write-accesses/,mmdc/write-bytes/ dd if=/dev/zero of= /dev/null bs=1M count=5000 5000+0 records in 5000+0 records out 5242880000 bytes (5.2 GB) copied, 5.4982 s, 954 MB/s Performance counter stats for 'system wide': 1597891298 mmdc/busy-cycles/ 28531959 mmdc/read-accesses/ 910.77 MB mmdc/read-bytes/ 2917082184 mmdc/total-cycles/ 27965222 mmdc/write-accesses/ 894.91 MB mmdc/write-bytes/ 5.527407668 seconds time elapsed But still need to check why the automatic power saving mode is not getting enabled in my board. Any help/guidance on the same will be appreciated. Signed-off-by: Nitin Chaudhary <Nitin.Chaudhary@zii.aero> --- arch/arm/mach-imx/mmdc.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 2.7.4