From patchwork Thu Aug 18 11:57:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gurucharan Shetty X-Patchwork-Id: 660557 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3sFg3p0P5jz9sxN for ; Fri, 19 Aug 2016 07:59:17 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 5732B10ADC; Thu, 18 Aug 2016 14:59:15 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e3.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id A737310ADA for ; Thu, 18 Aug 2016 14:59:13 -0700 (PDT) Received: from bar5.cudamail.com (localhost [127.0.0.1]) by mx1e3.cudamail.com (Postfix) with ESMTPS id 0359E4200BB for ; Thu, 18 Aug 2016 15:59:13 -0600 (MDT) X-ASG-Debug-ID: 1471557552-09eadd4c6854cb0001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar5.cudamail.com with ESMTP id x2x5XUmsnsvfn3n5 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 18 Aug 2016 15:59:12 -0600 (MDT) X-Barracuda-Envelope-From: guru.ovn@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO mail-pa0-f68.google.com) (209.85.220.68) by mx3-pf2.cudamail.com with ESMTPS (AES128-SHA encrypted); 18 Aug 2016 21:59:12 -0000 Received-SPF: pass (mx3-pf2.cudamail.com: SPF record at _netblocks.google.com designates 209.85.220.68 as permitted sender) X-Barracuda-Apparent-Source-IP: 209.85.220.68 X-Barracuda-RBL-IP: 209.85.220.68 Received: by mail-pa0-f68.google.com with SMTP id ez1so2415624pab.3 for ; Thu, 18 Aug 2016 14:59:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=4cJgSF7F0bgoxJ7zcCqCLaZpW3SHlR0b+1bM18AMF30=; b=KxOMyGMzzmwlM+KL6aaDIPLutM5IE1mSkhq9jY9YPW0ibzaYncGGSBiKRMbWqMsBAb aKia5M3hv+RKbBLLcjF8jZJggMDEWGwHMrlvK1TiUMrCgYSlLaPfDuX8PKDxaz9m4MfM Sqy5gjNABFuj7GdeysBTMiFyiRsbI8ru/S2rdSoobjev5sJj2MoBWv3c4a068E87KbHi +VBdwSL3GmmZHGrmqA+CXyZ8gh37oMradbt46JHiVKfrhNUHzN/hUAkpFLEwO/fY0GXC Qpka9Y4Lc0lKWO6TtEOv5+6XDOb7IhFe8Y2fnusChAnunWizMUeqmk3Q84v+aCjxHQhq C9Nw== X-Gm-Message-State: AEkooutcPOwL+ZnJZKQIt5JkZLYjVa/qRFLOELraB5/KA9aW0Dk1dzMWX6/57vmAzkj3Sg== X-Received: by 10.66.147.234 with SMTP id tn10mr8028310pab.144.1471557551384; Thu, 18 Aug 2016 14:59:11 -0700 (PDT) Received: from ubuntu.eng.vmware.com ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id v26sm1064664pfi.41.2016.08.18.14.59.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Aug 2016 14:59:10 -0700 (PDT) X-CudaMail-Envelope-Sender: guru.ovn@gmail.com From: Gurucharan Shetty To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V2-817049129 X-CudaMail-DTE: 081816 X-CudaMail-Originating-IP: 209.85.220.68 Date: Thu, 18 Aug 2016 04:57:42 -0700 X-ASG-Orig-Subj: [##CM-V2-817049129##][PATCH] ovn-controller: Don't clear desired groups during backlog. Message-Id: <1471521462-10113-1-git-send-email-guru@ovn.org> X-Mailer: git-send-email 1.9.1 X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1471557552 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Subject: [ovs-dev] [PATCH] ovn-controller: Don't clear desired groups during backlog. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" Doing so would mean that we will lose the desired groups forever because of incremental processing (till the next change in NB database). Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff --- ovn/controller/ofctrl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c index d7b3d3e..1fed1e8 100644 --- a/ovn/controller/ofctrl.c +++ b/ovn/controller/ofctrl.c @@ -920,7 +920,6 @@ ofctrl_put(int64_t nb_cfg) * between ovn-controller and OVS provides some buffering.) */ if (state != S_UPDATE_FLOWS || rconn_packet_counter_n_packets(tx_counter)) { - ovn_group_table_clear(groups, false); return; }