[ovs-dev] ovn-controller: Don't clear desired groups during backlog.
diff mbox

Message ID 1471521462-10113-1-git-send-email-guru@ovn.org
State Not Applicable
Headers show

Commit Message

Guru Shetty Aug. 18, 2016, 11:57 a.m. UTC
Doing so would mean that we will lose the desired groups forever
because of incremental processing (till the next change in NB database).

Signed-off-by: Gurucharan Shetty <guru@ovn.org>
---
 ovn/controller/ofctrl.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ben Pfaff Aug. 26, 2016, 8:38 p.m. UTC | #1
On Thu, Aug 18, 2016 at 04:57:42AM -0700, Gurucharan Shetty wrote:
> Doing so would mean that we will lose the desired groups forever
> because of incremental processing (till the next change in NB database).
> 
> Signed-off-by: Gurucharan Shetty <guru@ovn.org>

Probably this is not necessary with Ryan's patch to back out incremental
processing, but it's useful now.

Acked-by: Ben Pfaff <blp@ovn.org>

Patch
diff mbox

diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c
index d7b3d3e..1fed1e8 100644
--- a/ovn/controller/ofctrl.c
+++ b/ovn/controller/ofctrl.c
@@ -920,7 +920,6 @@  ofctrl_put(int64_t nb_cfg)
      * between ovn-controller and OVS provides some buffering.) */
     if (state != S_UPDATE_FLOWS
         || rconn_packet_counter_n_packets(tx_counter)) {
-        ovn_group_table_clear(groups, false);
         return;
     }