Patchwork [net-next] arp: remove unnecessary export of arp_broken_ops

login
register
mail settings
Submitter stephen hemminger
Date Sept. 29, 2010, 3:08 a.m.
Message ID <20100929120802.2f642d0d@s6510>
Download mbox | patch
Permalink /patch/66039/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Sept. 29, 2010, 3:08 a.m.
arp_broken_ops is only used in arp.c

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Sept. 30, 2010, 2:46 a.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 29 Sep 2010 12:08:02 +0900

> arp_broken_ops is only used in arp.c
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/include/net/arp.h	2010-09-29 10:36:46.125871462 +0900
+++ b/include/net/arp.h	2010-09-29 10:36:51.195923872 +0900
@@ -26,6 +26,4 @@  extern struct sk_buff *arp_create(int ty
 				  const unsigned char *target_hw);
 extern void arp_xmit(struct sk_buff *skb);
 
-extern const struct neigh_ops arp_broken_ops;
-
 #endif	/* _ARP_H */
--- a/net/ipv4/arp.c	2010-09-29 10:36:46.135874409 +0900
+++ b/net/ipv4/arp.c	2010-09-29 10:37:15.985915408 +0900
@@ -161,7 +161,7 @@  static const struct neigh_ops arp_direct
 	.queue_xmit =		dev_queue_xmit,
 };
 
-const struct neigh_ops arp_broken_ops = {
+static const struct neigh_ops arp_broken_ops = {
 	.family =		AF_INET,
 	.solicit =		arp_solicit,
 	.error_report =		arp_error_report,
@@ -170,7 +170,6 @@  const struct neigh_ops arp_broken_ops = 
 	.hh_output =		dev_queue_xmit,
 	.queue_xmit =		dev_queue_xmit,
 };
-EXPORT_SYMBOL(arp_broken_ops);
 
 struct neigh_table arp_tbl = {
 	.family		= AF_INET,