| Message ID | 1471505353-20289-1-git-send-email-arnout@mind.be |
|---|---|
| State | Rejected |
| Headers | show |
On Thu, Aug 18, 2016 at 9:29 AM, Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> wrote: > Commit dc6f4c8 forgot to give a type (string) to the newly introduced > BR2_LD_TARGET_EMULATION symbol. > > Possibly it was intended to be a "global" symbol like > BR2_GCC_TARGET_ABI where the declaration is in arch/Config.in and not > in the arch-specific Config.in. However, in this case, the symbol is > only defined/used for MIPS so there is no "global" declaration. > > Without this, Kconfig gives a warning: > arch/Config.in.mips:87:warning: config symbol defined without type > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Cc: Jan Heylen <heyleke@gmail.com> I assume so :-) Reviewed-by: Jan Heylen <heyleke@gmail.com> br, Jan > --- > arch/Config.in.mips | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/Config.in.mips b/arch/Config.in.mips > index 37e4bf6..ebc71de 100644 > --- a/arch/Config.in.mips > +++ b/arch/Config.in.mips > @@ -85,6 +85,7 @@ config BR2_GCC_TARGET_ABI > default "64" if BR2_MIPS_NABI64 > > config BR2_LD_TARGET_EMULATION > + string > default "elf64ltsmip" if BR2_mips64el && BR2_MIPS_NABI64 > default "elf64btsmip" if BR2_mips64 && BR2_MIPS_NABI64 > default "elf32ltsmipn32" if BR2_mips64el && BR2_MIPS_NABI32 > -- > 2.8.1 >
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes: > Commit dc6f4c8 forgot to give a type (string) to the newly introduced > BR2_LD_TARGET_EMULATION symbol. Ehh, we don't have a dc6f4c8 commit. Are you referring to http://patchwork.ozlabs.org/patch/606691/ If so, is this a sneaky way of sending your acked-by? ;)
On 18-08-16 11:08, Peter Korsgaard wrote: >>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes: > > > Commit dc6f4c8 forgot to give a type (string) to the newly introduced > > BR2_LD_TARGET_EMULATION symbol. > > Ehh, we don't have a dc6f4c8 commit. Are you referring to > > http://patchwork.ozlabs.org/patch/606691/ > > If so, is this a sneaky way of sending your acked-by? ;) Oops... It looks like my master isn't clean, it still has a stack of patches I was about to review months ago (and my git pull does implicit rebase). And it seems I even forgot to apply http://patchwork.ozlabs.org/patch/606690/ which adds the "string" declaration to arch/Config.in... So I've marked this one as rejected. Sorry for the noise... Regards, Arnout
diff --git a/arch/Config.in.mips b/arch/Config.in.mips index 37e4bf6..ebc71de 100644 --- a/arch/Config.in.mips +++ b/arch/Config.in.mips @@ -85,6 +85,7 @@ config BR2_GCC_TARGET_ABI default "64" if BR2_MIPS_NABI64 config BR2_LD_TARGET_EMULATION + string default "elf64ltsmip" if BR2_mips64el && BR2_MIPS_NABI64 default "elf64btsmip" if BR2_mips64 && BR2_MIPS_NABI64 default "elf32ltsmipn32" if BR2_mips64el && BR2_MIPS_NABI32
Commit dc6f4c8 forgot to give a type (string) to the newly introduced BR2_LD_TARGET_EMULATION symbol. Possibly it was intended to be a "global" symbol like BR2_GCC_TARGET_ABI where the declaration is in arch/Config.in and not in the arch-specific Config.in. However, in this case, the symbol is only defined/used for MIPS so there is no "global" declaration. Without this, Kconfig gives a warning: arch/Config.in.mips:87:warning: config symbol defined without type Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Cc: Jan Heylen <heyleke@gmail.com> --- arch/Config.in.mips | 1 + 1 file changed, 1 insertion(+)