diff mbox

[net-next] sfc: avoid division by zero

Message ID c09b487a-af9d-be97-c32d-dd06323bc0c8@solarflare.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Edward Cree Aug. 17, 2016, 3 p.m. UTC 
The division is already being done properly in efx_ef10_get_timer_config
which returns zero-on-success, unlike the old efx_ef10_get_sysclk_freq.

Fixes: d95e329a55ba ("sfc: get timer configuration from adapter")
Signed-off-by: Edward Cree <ecree@solarflare.com>
---
 drivers/net/ethernet/sfc/ef10.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller Aug. 19, 2016, 6:28 a.m. UTC | #1 
From: Edward Cree <ecree@solarflare.com>
Date: Wed, 17 Aug 2016 16:00:10 +0100

> The division is already being done properly in efx_ef10_get_timer_config
> which returns zero-on-success, unlike the old efx_ef10_get_sysclk_freq.
> 
> Fixes: d95e329a55ba ("sfc: get timer configuration from adapter")
> Signed-off-by: Edward Cree <ecree@solarflare.com>

Applied.
diff mbox

Patch

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index b8c9f18..2a70b1a 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -646,7 +646,6 @@  static int efx_ef10_probe(struct efx_nic *efx)
 	rc = efx_ef10_get_timer_config(efx);
 	if (rc < 0)
 		goto fail5;
-	efx->timer_quantum_ns = 1536000 / rc; /* 1536 cycles */
 
 	rc = efx_mcdi_mon_probe(efx);
 	if (rc && rc != -EPERM)