From patchwork Tue Sep 28 17:11:11 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Allow Solaris 2/x86 ABI to match recent Studio compiler (PR
 target/44452)
From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
X-Patchwork-Id: 66007
Message-Id: <ydd8w2lvln4.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Chris Quenelle <chris.quenelle@oracle.com>,
 Nathan Sidwell <nathan@codesourcery.com>
Date: Tue, 28 Sep 2010 19:11:11 +0200

Uros Bizjak <ubizjak@gmail.com> writes:

> Generic x86 part is OK.

Thanks.  Unfortunately, I hadn't noticed that the approval didn't apply
to the vx-common.h part and checked in the patch.  I hope that won't
cause any trouble.

>> 2010-09-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>>
>>        gcc/testsuite:
>>        PR target/44452
>>        * gcc.target/i386/abi-2.c: XFAIL on i?86-*-solaris2* && ilp32.
>>        * gcc.target/i386/pr22076.c: Likewise.
>
> Just skip pr22076.c on solaris targets, no need for so many complications.
>
> OK with this change.

Fine with me.  Here's what I've checked into the 4.4 and 4.5 branches
after testing with runtest and DEJAGNU pointing to a site.exp that
exercised both 32 and 64-bit multilibs to make sure only the 32-bit test
is skipped.

Thanks.
	Rainer


2010-09-26  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR target/44452
	* gcc.target/i386/abi-2.c: XFAIL on i?86-*-solaris2* && ilp32.
	* gcc.target/i386/pr22076.c: Skip on i?86-solaris2* && ilp32.

diff -r ce8a598bd7f1 gcc/testsuite/gcc.target/i386/abi-2.c
--- a/gcc/testsuite/gcc.target/i386/abi-2.c	Tue Sep 28 18:35:47 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/abi-2.c	Tue Sep 28 18:49:28 2010 +0200
@@ -6,4 +6,5 @@
 typedef long long __m256i __attribute__ ((__vector_size__ (32)));
 __m256i foo (void) { return (__m256i){ 1, 2, 3, 4 }; }
 
-/* { dg-final { scan-assembler-times "ymm0" 1 } } */
+/* Fails on 32-bit Solaris 2/x86: PR target/44452 */
+/* { dg-final { scan-assembler-times "ymm0" 1 { xfail { i?86-*-solaris2* && ilp32 } } } } */
diff -r ce8a598bd7f1 gcc/testsuite/gcc.target/i386/pr22076.c
--- a/gcc/testsuite/gcc.target/i386/pr22076.c	Tue Sep 28 18:35:47 2010 +0200
+++ b/gcc/testsuite/gcc.target/i386/pr22076.c	Tue Sep 28 18:49:28 2010 +0200
@@ -1,4 +1,5 @@
-/* { dg-do compile } */
+/* Fails on 32-bit Solaris 2/x86: PR target/44452 */
+/* { dg-do compile { target { ! { i?86-*-solaris2* && ilp32 } } } } */
 /* { dg-options "-O2 -fomit-frame-pointer -flax-vector-conversions -mmmx" } */
 
 #include <mmintrin.h>