| Message ID | 1471418009-12660-5-git-send-email-hs@denx.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Andreas Bießmann |
| Headers | show |
> -----Original Message----- > From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Heiko > Schocher > Sent: 2016年8月17日 15:13 > To: U-Boot Mailing List <u-boot@lists.denx.de> > Cc: Bo Shen <voice.shen@atmel.com> > Subject: [U-Boot] [PATCH 4/6] arm, at91: add some missing fields in PIO struct > > add missing > > u32 io_delay; /* 0x110 I/O delay register */ > u32 io_driver1; /* 0x114 I/O driver register 1 */ > u32 io_driver2; /* 0x118 I/O driver register 2 */ > > fields in struct at91_port. > > Signed-off-by: Heiko Schocher <hs@denx.de> Acked-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > > arch/arm/mach-at91/include/mach/at91_pio.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/include/mach/at91_pio.h b/arch/arm/mach- > at91/include/mach/at91_pio.h > index 3012278..8e054e1 100644 > --- a/arch/arm/mach-at91/include/mach/at91_pio.h > +++ b/arch/arm/mach-at91/include/mach/at91_pio.h > @@ -103,7 +103,11 @@ typedef struct at91_port { > u32 wpsr; /* 0xE8 Write Protect Status Register */ > u32 reserved11[5]; /* */ > u32 schmitt; /* 0x100 Schmitt Trigger Register */ > - u32 reserved12[63]; > + u32 reserved12[3]; > + u32 io_delay; /* 0x110 I/O delay register */ > + u32 io_driver1; /* 0x114 I/O driver register 1 */ > + u32 io_driver2; /* 0x118 I/O driver register 2 */ > + u32 reserved13[57]; > #else > u32 reserved6[85]; > #endif > -- > 2.5.5 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
On 17.08.16 09:13, Heiko Schocher wrote: > add missing > > u32 io_delay; /* 0x110 I/O delay register */ > u32 io_driver1; /* 0x114 I/O driver register 1 */ > u32 io_driver2; /* 0x118 I/O driver register 2 */ This is also a mess ... it is true for sam9x5, but sama5d4 has 0x110 reserved, 0x114 reserved and 0x118 I/O driver register 1, same for sama5d3 and persumably others ... Why is is needed here? Couldn't we switch to device tree on the long run? Andreas > > fields in struct at91_port. > > Signed-off-by: Heiko Schocher <hs@denx.de> > --- > > arch/arm/mach-at91/include/mach/at91_pio.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/include/mach/at91_pio.h b/arch/arm/mach-at91/include/mach/at91_pio.h > index 3012278..8e054e1 100644 > --- a/arch/arm/mach-at91/include/mach/at91_pio.h > +++ b/arch/arm/mach-at91/include/mach/at91_pio.h > @@ -103,7 +103,11 @@ typedef struct at91_port { > u32 wpsr; /* 0xE8 Write Protect Status Register */ > u32 reserved11[5]; /* */ > u32 schmitt; /* 0x100 Schmitt Trigger Register */ > - u32 reserved12[63]; > + u32 reserved12[3]; > + u32 io_delay; /* 0x110 I/O delay register */ > + u32 io_driver1; /* 0x114 I/O driver register 1 */ > + u32 io_driver2; /* 0x118 I/O driver register 2 */ > + u32 reserved13[57]; > #else > u32 reserved6[85]; > #endif >
diff --git a/arch/arm/mach-at91/include/mach/at91_pio.h b/arch/arm/mach-at91/include/mach/at91_pio.h index 3012278..8e054e1 100644 --- a/arch/arm/mach-at91/include/mach/at91_pio.h +++ b/arch/arm/mach-at91/include/mach/at91_pio.h @@ -103,7 +103,11 @@ typedef struct at91_port { u32 wpsr; /* 0xE8 Write Protect Status Register */ u32 reserved11[5]; /* */ u32 schmitt; /* 0x100 Schmitt Trigger Register */ - u32 reserved12[63]; + u32 reserved12[3]; + u32 io_delay; /* 0x110 I/O delay register */ + u32 io_driver1; /* 0x114 I/O driver register 1 */ + u32 io_driver2; /* 0x118 I/O driver register 2 */ + u32 reserved13[57]; #else u32 reserved6[85]; #endif
add missing u32 io_delay; /* 0x110 I/O delay register */ u32 io_driver1; /* 0x114 I/O driver register 1 */ u32 io_driver2; /* 0x118 I/O driver register 2 */ fields in struct at91_port. Signed-off-by: Heiko Schocher <hs@denx.de> --- arch/arm/mach-at91/include/mach/at91_pio.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)