diff mbox

[for-2.8,v3,1/3] scripts: Allow block module to not define BlockDriver

Message ID 1471418433-20061-2-git-send-email-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng Aug. 17, 2016, 7:20 a.m. UTC 
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 scripts/modules/module_block.py | 5 -----
 1 file changed, 5 deletions(-)

Comments

Max Reitz Aug. 29, 2016, 1:11 p.m. UTC | #1 
On 17.08.2016 09:20, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  scripts/modules/module_block.py | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/scripts/modules/module_block.py b/scripts/modules/module_block.py
> index db4fb54..7efec00 100644
> --- a/scripts/modules/module_block.py
> +++ b/scripts/modules/module_block.py
> @@ -56,11 +56,6 @@ def process_file(fheader, filename):
>                  format_name = ""
>                  protocol_name = ""
>  
> -        if not found_something:
> -            print("No BlockDriver struct found in " + filename + ". \
> -                    Is this really a module?", file=sys.stderr)
> -            sys.exit(1)

found_something is now unused. Do you want to remove it?

Max

> -
>  def print_top(fheader):
>      fheader.write('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */
>  /*
>
diff mbox

Patch

diff --git a/scripts/modules/module_block.py b/scripts/modules/module_block.py
index db4fb54..7efec00 100644
--- a/scripts/modules/module_block.py
+++ b/scripts/modules/module_block.py
@@ -56,11 +56,6 @@  def process_file(fheader, filename):
                 format_name = ""
                 protocol_name = ""
 
-        if not found_something:
-            print("No BlockDriver struct found in " + filename + ". \
-                    Is this really a module?", file=sys.stderr)
-            sys.exit(1)
-
 def print_top(fheader):
     fheader.write('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */
 /*