diff mbox

net: atm: remove redundant null pointer check on dev->name

Message ID 1471345722-19203-1-git-send-email-colin.king@canonical.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Colin Ian King Aug. 16, 2016, 11:08 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

dev->name is a char array of IFNAMSIZ elements, hence can never be
null, so the null pointer check is redundant. Remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/atm/mpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Aug. 19, 2016, 4:04 a.m. UTC | #1 
From: Colin King <colin.king@canonical.com>
Date: Tue, 16 Aug 2016 12:08:42 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> dev->name is a char array of IFNAMSIZ elements, hence can never be
> null, so the null pointer check is redundant. Remove it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.
diff mbox

Patch

diff --git a/net/atm/mpc.c b/net/atm/mpc.c
index 0e98222..3b3b1a2 100644
--- a/net/atm/mpc.c
+++ b/net/atm/mpc.c
@@ -1007,7 +1007,7 @@  static int mpoa_event_listener(struct notifier_block *mpoa_notifier,
 	if (!net_eq(dev_net(dev), &init_net))
 		return NOTIFY_DONE;
 
-	if (dev->name == NULL || strncmp(dev->name, "lec", 3))
+	if (strncmp(dev->name, "lec", 3))
 		return NOTIFY_DONE; /* we are only interested in lec:s */
 
 	switch (event) {