| Message ID | 1471343175-14945-17-git-send-email-vsementsov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 08/16 13:26, Vladimir Sementsov-Ogievskiy wrote: > When testing migration, auto-generated by qemu node-names differs in > source and destination qemu and migration fails. After this patch, > auto-generated by iotest nodenames will be the same. Does this mean if a real user doesn't specify node-name, migration will fail too? Fam > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > tests/qemu-iotests/iotests.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index 37c0f63..0332589 100644 > --- a/tests/qemu-iotests/iotests.py > +++ b/tests/qemu-iotests/iotests.py > @@ -147,7 +147,8 @@ class VM(qtest.QEMUQtestMachine): > def add_drive(self, path, opts='', interface='virtio'): > '''Add a virtio-blk drive to the VM''' > options = ['if=%s' % interface, > - 'id=drive%d' % self._num_drives] > + 'id=drive%d' % self._num_drives, > + 'node-name=drivenode%d' % self._num_drives] > > if path is not None: > options.append('file=%s' % path) > -- > 1.8.3.1 > >
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 37c0f63..0332589 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -147,7 +147,8 @@ class VM(qtest.QEMUQtestMachine): def add_drive(self, path, opts='', interface='virtio'): '''Add a virtio-blk drive to the VM''' options = ['if=%s' % interface, - 'id=drive%d' % self._num_drives] + 'id=drive%d' % self._num_drives, + 'node-name=drivenode%d' % self._num_drives] if path is not None: options.append('file=%s' % path)
When testing migration, auto-generated by qemu node-names differs in source and destination qemu and migration fails. After this patch, auto-generated by iotest nodenames will be the same. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)