diff mbox

[2/2,libnfntl] expr: cmp: Use cmp2str() instead of directly access to array

Message ID 20160815105103.22319-2-carlosfg@riseup.net
State Accepted
Delegated to: Pablo Neira
Headers show

Commit Message

Carlos Falgueras García Aug. 15, 2016, 10:51 a.m. UTC
Uses cmp2str() which checks array bounds.

Signed-off-by: Carlos Falgueras García <carlosfg@riseup.net>
---
 src/expr/cmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso Aug. 15, 2016, 11:49 a.m. UTC | #1
On Mon, Aug 15, 2016 at 12:51:03PM +0200, Carlos Falgueras García wrote:
> Uses cmp2str() which checks array bounds.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/src/expr/cmp.c b/src/expr/cmp.c
index f3dd62c..5d51958 100644
--- a/src/expr/cmp.c
+++ b/src/expr/cmp.c
@@ -267,7 +267,7 @@  static int nftnl_expr_cmp_snprintf_default(char *buf, size_t size,
 	int len = size, offset = 0, ret;
 
 	ret = snprintf(buf, len, "%s reg %u ",
-		       expr_cmp_str[cmp->op], cmp->sreg);
+		       cmp2str(cmp->op), cmp->sreg);
 	SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
 
 	ret = nftnl_data_reg_snprintf(buf+offset, len, &cmp->data,