From patchwork Fri Aug 12 19:42:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gurucharan Shetty X-Patchwork-Id: 658855 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3s9wJM5Hgsz9sR8 for ; Sat, 13 Aug 2016 05:42:10 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 836DA10DB2; Fri, 12 Aug 2016 12:42:09 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e4.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id 9394510CFC for ; Fri, 12 Aug 2016 12:42:08 -0700 (PDT) Received: from bar5.cudamail.com (unknown [192.168.21.12]) by mx1e4.cudamail.com (Postfix) with ESMTPS id 192AF1E04BB for ; Fri, 12 Aug 2016 13:42:08 -0600 (MDT) X-ASG-Debug-ID: 1471030927-09eadd42f202020001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar5.cudamail.com with ESMTP id TG2qw1bRT8Uuqc2C (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 12 Aug 2016 13:42:07 -0600 (MDT) X-Barracuda-Envelope-From: guru@ovn.org X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO relay9-d.mail.gandi.net) (217.70.183.199) by mx3-pf3.cudamail.com with ESMTPS (DHE-RSA-AES256-SHA encrypted); 12 Aug 2016 19:42:06 -0000 Received-SPF: pass (mx3-pf3.cudamail.com: SPF record at ovn.org designates 217.70.183.199 as permitted sender) X-Barracuda-Apparent-Source-IP: 217.70.183.199 X-Barracuda-RBL-IP: 217.70.183.199 Received: from mfilter43-d.gandi.net (mfilter43-d.gandi.net [217.70.178.174]) by relay9-d.mail.gandi.net (Postfix) with ESMTP id 893E4406E0 for ; Fri, 12 Aug 2016 21:42:04 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter43-d.gandi.net Received: from relay9-d.mail.gandi.net ([IPv6:::ffff:217.70.183.199]) by mfilter43-d.gandi.net (mfilter43-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id qwr9pf0pV4oF for ; Fri, 12 Aug 2016 21:42:02 +0200 (CEST) X-Originating-IP: 74.125.82.41 Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) (Authenticated sender: guru@ovn.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 8734D40367 for ; Fri, 12 Aug 2016 21:42:02 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id q128so45301743wma.1 for ; Fri, 12 Aug 2016 12:42:02 -0700 (PDT) X-Gm-Message-State: AEkoout4Y/wtDyzHDwjFz3aQaXDNUa/pDj397jYMuPifJwzhlt5PKxVN2Jy0JmW2Wrzmol/aZ4v6uzf5eCUyxw== X-Received: by 10.25.33.130 with SMTP id h124mr2716604lfh.47.1471030921985; Fri, 12 Aug 2016 12:42:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.114.5.232 with HTTP; Fri, 12 Aug 2016 12:42:01 -0700 (PDT) In-Reply-To: References: <1470983677-7638-1-git-send-email-guru@ovn.org> <1470983677-7638-2-git-send-email-guru@ovn.org> X-CudaMail-Envelope-Sender: guru@ovn.org From: Guru Shetty Date: Fri, 12 Aug 2016 12:42:01 -0700 X-Gmail-Original-Message-ID: Message-ID: X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V3-811036972 X-CudaMail-DTE: 081216 X-CudaMail-Originating-IP: 217.70.183.199 To: Joe Stringer X-ASG-Orig-Subj: [##CM-V3-811036972##]Re: [ovs-dev] [PATCH 2/2] system-ovn.at: Add another load-balancing test. X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1471030927 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: ovs dev Subject: Re: [ovs-dev] [PATCH 2/2] system-ovn.at: Add another load-balancing test. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On 12 August 2016 at 11:15, Joe Stringer wrote: > On 11 August 2016 at 23:34, Gurucharan Shetty wrote: > > The client and servers are in the same subnet. > > > > (This would not have worked without the recent > > IPv6 patches that let packets to loop back) > > > > Signed-off-by: Gurucharan Shetty > > This test should be skipped for the "check-system-userspace" make > target (this is done for the other OVN LB and NAT tests, so I guess > you already know how). > I need to add a CHECK_CONNTRACK_NAT() check for that. I will do it. > > > I'm seeing some basic failures running this test in the kernel > testsuite on recent kernels (not sure if it is related to kernel > version or not, but it's v4.2 and net-next): > Thanks. The failure looks to be because it was not load-balanced across all servers in the 12 tries that it did. I will add the following incremental in v2 ( I haven't seen any failures in 100 runs. I will also add a similar increase in tries as part of the first patch for previous lb test): index 68dc3c8..23f1bf8 100755 -o wget$i.log done @@ -506,7 +507,7 @@ tcp,orig=(src=192.168.1.2,dst=30.0.0.1,sport=,dport= > ./system-ovn.at:515: ovs-appctl dpctl/dump-conntrack | grep > "dst=30.0.0.2" | sed -e 's/port=[0-9]*/port=/g' -e > 's/id=[0-9]*/id=/g' -e 's/state=[0-9_A-Z]*/state=/g' > | sort | uniq > --- - 2016-08-12 18:07:19.603786916 +0000 > +++ /home/gitlab-runner/builds/83c49bff/0/root/openvswitch/ > tests/system-kmod-testsuite.dir/at-groups/61/stdout > 2016-08-12 18:07:19.602000000 +0000 > @@ -1,4 +1,3 @@ > tcp,orig=(src=192.168.1.2,dst=30.0.0.2,sport=, > dport=),reply=(src=192.168.1.3,dst=192.168.1.2, > sport=,dport=),protoinfo=(state=) > tcp,orig=(src=192.168.1.2,dst=30.0.0.2,sport=, > dport=),reply=(src=192.168.1.4,dst=192.168.1.2, > sport=,dport=),protoinfo=(state=) > -tcp,orig=(src=192.168.1.2,dst=30.0.0.2,sport=, > dport=),reply=(src=192.168.1.5,dst=192.168.1.2, > sport=,dport=),protoinfo=(state=) > --- a/tests/system-ovn.at +++ b/tests/system-ovn.at @@ -421,6 +421,7 @@ AT_SETUP([ovn -- load-balancing - same subnet.]) AT_KEYWORDS([ovnlb]) CHECK_CONNTRACK() +CHECK_CONNTRACK_NAT() ovn_start OVS_TRAFFIC_VSWITCHD_START() ADD_BR([br-int]) @@ -493,7 +494,7 @@ NETNS_DAEMONIZE([foo3], [[$PYTHON $srcdir/test-l7.py]], [http2.pid]) NETNS_DAEMONIZE([foo4], [[$PYTHON $srcdir/test-l7.py]], [http3.pid]) dnl Should work with the virtual IP address through NAT -for i in 1 2 3 4 5 6 7 8 9 10 11 12; do +for i in `seq 1 20`; do echo Request $i NS_CHECK_EXEC([foo1], [wget 30.0.0.1 -t 5 -T 1 --retry-connrefused -v