diff mbox

ravb: use proper names for suspend/resume functions

Message ID 20160810110949.16608-1-niklas.soderlund+renesas@ragnatech.se
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Niklas Söderlund Aug. 10, 2016, 11:09 a.m. UTC
The patch 'ravb: add sleep PM suspend/resume support' used incorrect
function names containing 'runtime' for the suspend and resume
functions.

Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/net/ethernet/renesas/ravb_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Sergei Shtylyov Aug. 10, 2016, 11:16 a.m. UTC | #1
On 8/10/2016 2:09 PM, Niklas Söderlund wrote:

> The patch 'ravb: add sleep PM suspend/resume support' used incorrect

    Actually, that patch should now have immutable SHA1 ID.

> function names containing 'runtime' for the suspend and resume
> functions.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei
David Miller Aug. 10, 2016, 9:52 p.m. UTC | #2
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Date: Wed, 10 Aug 2016 13:09:49 +0200

> The patch 'ravb: add sleep PM suspend/resume support' used incorrect
> function names containing 'runtime' for the suspend and resume
> functions.
> 
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 256565e..d4809ad 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2104,7 +2104,7 @@  static int ravb_remove(struct platform_device *pdev)
 }
 
 #ifdef CONFIG_PM
-static int ravb_runtime_suspend(struct device *dev)
+static int ravb_suspend(struct device *dev)
 {
 	struct net_device *ndev = dev_get_drvdata(dev);
 	int ret = 0;
@@ -2117,7 +2117,7 @@  static int ravb_runtime_suspend(struct device *dev)
 	return ret;
 }
 
-static int ravb_runtime_resume(struct device *dev)
+static int ravb_resume(struct device *dev)
 {
 	struct net_device *ndev = dev_get_drvdata(dev);
 	struct ravb_private *priv = netdev_priv(ndev);
@@ -2165,7 +2165,7 @@  static int ravb_runtime_nop(struct device *dev)
 }
 
 static const struct dev_pm_ops ravb_dev_pm_ops = {
-	SET_SYSTEM_SLEEP_PM_OPS(ravb_runtime_suspend, ravb_runtime_resume)
+	SET_SYSTEM_SLEEP_PM_OPS(ravb_suspend, ravb_resume)
 	SET_RUNTIME_PM_OPS(ravb_runtime_nop, ravb_runtime_nop, NULL)
 };