Patchwork Objc - remove obsolete comment

login
register
mail settings
Submitter Nicola Pero
Date Sept. 24, 2010, 6:15 p.m.
Message ID <1285352102.48567330@192.168.2.229>
Download mbox | patch
Permalink /patch/65674/
State New
Headers show

Comments

Nicola Pero - Sept. 24, 2010, 6:15 p.m.
Ok to apply ?

Thanks
Chris Lattner - Sept. 24, 2010, 6:22 p.m.
Wow, monumental day.  Aren't you worried about stepstone 3.3 compatibility anymore? ;-)

-Chris

On Sep 24, 2010, at 11:15 AM, Nicola Pero wrote:

> Ok to apply ?
> 
> Thanks
> 
> Index: objc-act.c
> ===================================================================
> --- objc-act.c  (revision 164584)
> +++ objc-act.c  (working copy)
> @@ -20,26 +20,6 @@ You should have received a copy of the GNU General
> along with GCC; see the file COPYING3.  If not see
> <http://www.gnu.org/licenses/>.  */
> 
> -
> -/* Purpose: This module implements the Objective-C 4.0 language.
> -
> -   compatibility issues (with the Stepstone translator):
> -
> -   - does not recognize the following 3.3 constructs.
> -     @requires, @classes, @messages, = (...)
> -   - methods with variable arguments must conform to ANSI standard.
> -   - tagged structure definitions that appear in BOTH the interface
> -     and implementation are not allowed.
> -   - public/private: all instance variables are public within the
> -     context of the implementation...I consider this to be a bug in
> -     the translator.
> -   - statically allocated objects are not supported. the user will
> -     receive an error if this service is requested.
> -
> -   code generation `options':
> -
> -   */
> -
> #include "config.h"
> #include "system.h"
> #include "coretypes.h"
> Index: ChangeLog
> ===================================================================
> --- ChangeLog   (revision 164584)
> +++ ChangeLog   (working copy)
> @@ -1,3 +1,8 @@
> +2010-09-24  Nicola Pero  <nicola.pero@meta-innovation.com>
> +
> +       * objc-act.c: Removed historical, obsolete comment at the top of
> +       the file.
> +
> 2010-09-21  Nicola Pero  <nicola.pero@meta-innovation.com>
> 
>        PR objc/23710
> 
>
Nicola Pero - Sept. 24, 2010, 6:35 p.m.
I actually don't mind the comment.  If you *know* it's a historical comment,
it is nice - it is like having a very old inscripted stone in the front wall
of your building ;-)

But then you're not the first one that bashes GCC for having that old comment
in there, which is precisely why I want to get rid of it.

Thanks

-----Original Message-----
From: "Chris Lattner" <clattner@apple.com>
Sent: Friday, 24 September, 2010 20:22
To: "Nicola Pero" <nicola.pero@meta-innovation.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Objc - remove obsolete comment

Wow, monumental day.  Aren't you worried about stepstone 3.3 compatibility anymore? ;-)

-Chris

On Sep 24, 2010, at 11:15 AM, Nicola Pero wrote:

> Ok to apply ?
> 
> Thanks
> 
> Index: objc-act.c
> ===================================================================
> --- objc-act.c  (revision 164584)
> +++ objc-act.c  (working copy)
> @@ -20,26 +20,6 @@ You should have received a copy of the GNU General
> along with GCC; see the file COPYING3.  If not see
> <http://www.gnu.org/licenses/>.  */
> 
> -
> -/* Purpose: This module implements the Objective-C 4.0 language.
> -
> -   compatibility issues (with the Stepstone translator):
> -
> -   - does not recognize the following 3.3 constructs.
> -     @requires, @classes, @messages, = (...)
> -   - methods with variable arguments must conform to ANSI standard.
> -   - tagged structure definitions that appear in BOTH the interface
> -     and implementation are not allowed.
> -   - public/private: all instance variables are public within the
> -     context of the implementation...I consider this to be a bug in
> -     the translator.
> -   - statically allocated objects are not supported. the user will
> -     receive an error if this service is requested.
> -
> -   code generation `options':
> -
> -   */
> -
> #include "config.h"
> #include "system.h"
> #include "coretypes.h"
> Index: ChangeLog
> ===================================================================
> --- ChangeLog   (revision 164584)
> +++ ChangeLog   (working copy)
> @@ -1,3 +1,8 @@
> +2010-09-24  Nicola Pero  <nicola.pero@meta-innovation.com>
> +
> +       * objc-act.c: Removed historical, obsolete comment at the top of
> +       the file.
> +
> 2010-09-21  Nicola Pero  <nicola.pero@meta-innovation.com>
> 
>        PR objc/23710
> 
>
Mike Stump - Sept. 26, 2010, 6:45 p.m.
On Sep 24, 2010, at 11:15 AM, Nicola Pero wrote:
> Ok to apply ?

Hum, strange, you actually read the comments in code?  :-)

Ok.

Patch

Index: objc-act.c
===================================================================
--- objc-act.c  (revision 164584)
+++ objc-act.c  (working copy)
@@ -20,26 +20,6 @@  You should have received a copy of the GNU General
 along with GCC; see the file COPYING3.  If not see
 <http://www.gnu.org/licenses/>.  */
 
-
-/* Purpose: This module implements the Objective-C 4.0 language.
-
-   compatibility issues (with the Stepstone translator):
-
-   - does not recognize the following 3.3 constructs.
-     @requires, @classes, @messages, = (...)
-   - methods with variable arguments must conform to ANSI standard.
-   - tagged structure definitions that appear in BOTH the interface
-     and implementation are not allowed.
-   - public/private: all instance variables are public within the
-     context of the implementation...I consider this to be a bug in
-     the translator.
-   - statically allocated objects are not supported. the user will
-     receive an error if this service is requested.
-
-   code generation `options':
-
-   */
-
 #include "config.h"
 #include "system.h"
 #include "coretypes.h"
Index: ChangeLog
===================================================================
--- ChangeLog   (revision 164584)
+++ ChangeLog   (working copy)
@@ -1,3 +1,8 @@ 
+2010-09-24  Nicola Pero  <nicola.pero@meta-innovation.com>
+
+       * objc-act.c: Removed historical, obsolete comment at the top of
+       the file.
+
 2010-09-21  Nicola Pero  <nicola.pero@meta-innovation.com>
 
        PR objc/23710