| Message ID | 1470564546-8008-1-git-send-email-opensource.dxs@aliyun.com |
|---|---|
| State | New |
| Headers | show |
On Sun, Aug 7, 2016 at 5:48 PM Stefano Dong (董兴水) <opensource.dxs@aliyun.com> wrote: > When Debug switch is open, this debug message will print again in > function 'process_msg'. Delete it. > > Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > hw/misc/ivshmem.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index 40a2ebc..f803dfd 100644 > --- a/hw/misc/ivshmem.c > +++ b/hw/misc/ivshmem.c > @@ -628,7 +628,6 @@ static void ivshmem_read(void *opaque, const uint8_t > *buf, int size) > s->msg_buffered_bytes = 0; > > fd = qemu_chr_fe_get_msgfd(s->server_chr); > - IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd); > > process_msg(s, msg, fd, &err); > if (err) { > -- > 2.7.4 > > > -- Marc-André Lureau
This could go in via qemu-trivial. Stefano Dong (董兴水) <opensource.dxs@aliyun.com> writes: > When Debug switch is open, this debug message will print again in > function 'process_msg'. Delete it. Suggest to say "Duplicated in commit ca0b756. Delete it." > Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com> Reviewed-by: Markus Armbruster <armbru@redhat.com>
On 2016年08月08日 17:43, Markus Armbruster wrote: > This could go in via qemu-trivial. > > Stefano Dong (董兴水) <opensource.dxs@aliyun.com> writes: > >> When Debug switch is open, this debug message will print again in >> function 'process_msg'. Delete it. > > Suggest to say "Duplicated in commit ca0b756. Delete it." Ok, i'll update the log message and send the patch to qemu-trivial. Thanks! > >> Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com> > > Reviewed-by: Markus Armbruster <armbru@redhat.com> >
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 40a2ebc..f803dfd 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -628,7 +628,6 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size) s->msg_buffered_bytes = 0; fd = qemu_chr_fe_get_msgfd(s->server_chr); - IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd); process_msg(s, msg, fd, &err); if (err) {
When Debug switch is open, this debug message will print again in function 'process_msg'. Delete it. Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com> --- hw/misc/ivshmem.c | 1 - 1 file changed, 1 deletion(-)