diff mbox

tc/m_gact: Fix action_a2n() return code check

Message ID 20160807111621.6D056647E4@mail.nwl.cc
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Phil Sutter Aug. 7, 2016, 11:19 a.m. UTC 
The function returns zero on success.

Reported-by: Mark Bloch <markb@mellanox.com>
Fixes: 69f5aff63c770b ("tc: use action_a2n() everywhere")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 tc/m_gact.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger Aug. 8, 2016, 3:55 p.m. UTC | #1 
On Sun,  7 Aug 2016 13:19:01 +0200
Phil Sutter <phil@nwl.cc> wrote:

> The function returns zero on success.
> 
> Reported-by: Mark Bloch <markb@mellanox.com>
> Fixes: 69f5aff63c770b ("tc: use action_a2n() everywhere")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Applied
diff mbox

Patch

diff --git a/tc/m_gact.c b/tc/m_gact.c
index c0a938c716b6a..2bfd9a7c317e4 100644
--- a/tc/m_gact.c
+++ b/tc/m_gact.c
@@ -73,7 +73,7 @@  get_act(char ***argv_p)
 {
 	int n;
 
-	if (!action_a2n(**argv_p, &n, false)) {
+	if (action_a2n(**argv_p, &n, false)) {
 		fprintf(stderr, "bad action type %s\n", **argv_p);
 		return -10;
 	}