From patchwork Fri Sep 24 09:22:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinya Kuribayashi X-Patchwork-Id: 65632 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9A74FB70F4 for ; Fri, 24 Sep 2010 19:25:02 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1Oz4VC-00025n-Hh; Fri, 24 Sep 2010 09:23:34 +0000 Received: from tyo202.gate.nec.co.jp ([202.32.8.206]) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1Oz4V9-00024v-Hx for linux-mtd@lists.infradead.org; Fri, 24 Sep 2010 09:23:33 +0000 Received: from mailgate3.nec.co.jp ([10.7.69.197]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id o8O9NSQG004842 for ; Fri, 24 Sep 2010 18:23:28 +0900 (JST) Received: (from root@localhost) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) id o8O9NSx11350 for linux-mtd@lists.infradead.org; Fri, 24 Sep 2010 18:23:28 +0900 (JST) Received: from relay41.aps.necel.com ([10.29.19.9]) by vgate02.nec.co.jp (8.14.4/8.14.4) with ESMTP id o8O8xkF6029205 for ; Fri, 24 Sep 2010 18:23:27 +0900 (JST) Received: from realmbox31.aps.necel.com ([10.29.19.32] [10.29.19.32]) by relay41.aps.necel.com with ESMTP; Fri, 24 Sep 2010 18:23:27 +0900 Received: from [10.114.181.240] ([10.114.181.240] [10.114.181.240]) by mbox02.aps.necel.com with ESMTP; Fri, 24 Sep 2010 18:23:27 +0900 Message-ID: <4C9C6DED.5040200@renesas.com> Date: Fri, 24 Sep 2010 18:22:53 +0900 From: Shinya Kuribayashi User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.12) Gecko/20100824 Lightning/1.0b1 Thunderbird/3.0.7 MIME-Version: 1.0 To: linux-mtd@lists.infradead.org Subject: [PATCH] nandwrite: Remove redundant 'autoplace' check X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20100924_052332_166704_D837961A X-CRM114-Status: GOOD ( 13.65 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.1 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We're already in 'if (autoplace) { }' block at ths moment. Signed-off-by: Shinya Kuribayashi --- Along with Mike's nandwrite patches, I'd like to toss out a trivial one, too ;-) nandwrite.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/nandwrite.c b/nandwrite.c index 8fe8875..9eb2004 100644 --- a/nandwrite.c +++ b/nandwrite.c @@ -331,7 +331,7 @@ int main(int argc, char * const argv[]) } // autoplace ECC ? - if (autoplace && (old_oobinfo.useecc != MTD_NANDECC_AUTOPLACE)) { + if (old_oobinfo.useecc != MTD_NANDECC_AUTOPLACE) { if (ioctl (fd, MEMSETOOBSEL, &autoplace_oobinfo) != 0) { perror ("MEMSETOOBSEL");