[1/2] hooks/add-offb: Add leading slash to HVC node paths
diff mbox

Message ID 1470380712-3132-1-git-send-email-jk@ozlabs.org
State Accepted
Headers show

Commit Message

Jeremy Kerr Aug. 5, 2016, 7:05 a.m. UTC
We need an absolute path to the serial@N device. It looks like some
kernels aren't reading the current path correctly, leading to no console
output.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---
 utils/hooks/30-add-offb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith Aug. 8, 2016, 1:19 a.m. UTC | #1
Jeremy Kerr <jk@ozlabs.org> writes:
> We need an absolute path to the serial@N device. It looks like some
> kernels aren't reading the current path correctly, leading to no console
> output.
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

I tested that this was the issue by removing the 30-add-offb binary from
a Garrison system and seeing that the regression we had in booting a
well known enterprise linux distro installer went away.

Acked-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Samuel Mendoza-Jonas Aug. 8, 2016, 7:22 a.m. UTC | #2
On Fri, 2016-08-05 at 15:05 +0800, Jeremy Kerr wrote:
> We need an absolute path to the serial@N device. It looks like some
> kernels aren't reading the current path correctly, leading to no console
> output.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

Thanks! Merged asĀ 0611a74.

> ---
>  utils/hooks/30-add-offb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/hooks/30-add-offb.c b/utils/hooks/30-add-offb.c
> index d711908..e5947ca 100644
> --- a/utils/hooks/30-add-offb.c
> +++ b/utils/hooks/30-add-offb.c
> @@ -474,7 +474,7 @@ static char *get_hvc_path(struct offb_ctx *ctx, unsigned int termno)
>  		return NULL;
>  	}
>  
> -	return talloc_asprintf(ctx, "ibm,opal/consoles/%s", serial);
> +	return talloc_asprintf(ctx, "/ibm,opal/consoles/%s", serial);
>  }
>  
>  /*

Patch
diff mbox

diff --git a/utils/hooks/30-add-offb.c b/utils/hooks/30-add-offb.c
index d711908..e5947ca 100644
--- a/utils/hooks/30-add-offb.c
+++ b/utils/hooks/30-add-offb.c
@@ -474,7 +474,7 @@  static char *get_hvc_path(struct offb_ctx *ctx, unsigned int termno)
 		return NULL;
 	}
 
-	return talloc_asprintf(ctx, "ibm,opal/consoles/%s", serial);
+	return talloc_asprintf(ctx, "/ibm,opal/consoles/%s", serial);
 }
 
 /*