| Message ID | 1470349800-27521-2-git-send-email-pgynther@google.com |
|---|---|
| State | Superseded |
| Headers | show |
Hello, On Thu, 4 Aug 2016 15:29:59 -0700, Petri Gynther wrote: > Rename BR2_EXTRA_GCC_CONFIG_OPTIONS to BR2_GCC_EXTRA_CONFIG_OPTIONS > to be consistent with BR2_GCC_* and BR2_BINUTILS_EXTRA_CONFIG_OPTIONS. > > Signed-off-by: Petri Gynther <pgynther@google.com> Thanks for your contributions! However, for patch 2/3 and 3/3, which merely rename existing config options "for the sake of consistency", it means that they break all existing configurations. Even though I do like consistency, we generally try to avoid such renames "just for the beauty of it" in order to not break the existing configurations that our users have. Or at the very least, handling in Config.in.legacy should be added for the previous option name, so that users are notified that there is an issue when they upgrade Buildroot. Thomas
Hi Thomas, On Fri, Aug 5, 2016 at 12:46 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > > Hello, > > On Thu, 4 Aug 2016 15:29:59 -0700, Petri Gynther wrote: > > Rename BR2_EXTRA_GCC_CONFIG_OPTIONS to BR2_GCC_EXTRA_CONFIG_OPTIONS > > to be consistent with BR2_GCC_* and BR2_BINUTILS_EXTRA_CONFIG_OPTIONS. > > > > Signed-off-by: Petri Gynther <pgynther@google.com> > > Thanks for your contributions! > > However, for patch 2/3 and 3/3, which merely rename existing config > options "for the sake of consistency", it means that they break all > existing configurations. > > Even though I do like consistency, we generally try to avoid such > renames "just for the beauty of it" in order to not break the existing > configurations that our users have. > > Or at the very least, handling in Config.in.legacy should be added for > the previous option name, so that users are notified that there is an > issue when they upgrade Buildroot. I added the old options to Config.in.legacy. Sending out patch v2 for 2/3 and 3/3 shortly. > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host index 2b54959..a2946bc 100644 --- a/package/gcc/Config.in.host +++ b/package/gcc/Config.in.host @@ -109,7 +109,7 @@ config BR2_GCC_VERSION default "6.1.0" if BR2_GCC_VERSION_6_X default "arc-2016.09-eng007" if BR2_GCC_VERSION_4_8_ARC -config BR2_EXTRA_GCC_CONFIG_OPTIONS +config BR2_GCC_EXTRA_CONFIG_OPTIONS string "Additional gcc options" default "" help diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk index 284d34c..0c0ab35 100644 --- a/package/gcc/gcc-final/gcc-final.mk +++ b/package/gcc/gcc-final/gcc-final.mk @@ -90,7 +90,7 @@ endif # End with user-provided options, so that they can override previously # defined options. HOST_GCC_FINAL_CONF_OPTS += \ - $(call qstrip,$(BR2_EXTRA_GCC_CONFIG_OPTIONS)) + $(call qstrip,$(BR2_GCC_EXTRA_CONFIG_OPTIONS)) HOST_GCC_FINAL_CONF_ENV = \ $(HOST_GCC_COMMON_CONF_ENV) diff --git a/package/gcc/gcc-initial/gcc-initial.mk b/package/gcc/gcc-initial/gcc-initial.mk index 1e58d8b..0fba9fb 100644 --- a/package/gcc/gcc-initial/gcc-initial.mk +++ b/package/gcc/gcc-initial/gcc-initial.mk @@ -47,7 +47,7 @@ HOST_GCC_INITIAL_CONF_OPTS = \ --with-newlib \ --disable-largefile \ --disable-nls \ - $(call qstrip,$(BR2_EXTRA_GCC_CONFIG_OPTIONS)) + $(call qstrip,$(BR2_GCC_EXTRA_CONFIG_OPTIONS)) HOST_GCC_INITIAL_CONF_ENV = \ $(HOST_GCC_COMMON_CONF_ENV)
Rename BR2_EXTRA_GCC_CONFIG_OPTIONS to BR2_GCC_EXTRA_CONFIG_OPTIONS to be consistent with BR2_GCC_* and BR2_BINUTILS_EXTRA_CONFIG_OPTIONS. Signed-off-by: Petri Gynther <pgynther@google.com> --- package/gcc/Config.in.host | 2 +- package/gcc/gcc-final/gcc-final.mk | 2 +- package/gcc/gcc-initial/gcc-initial.mk | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)