diff mbox

[1/2] ravb: use SET_RUNTIME_PM_OPS macro

Message ID 20160803135647.23242-2-niklas.soderlund+renesas@ragnatech.se
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Niklas Söderlund Aug. 3, 2016, 1:56 p.m. UTC
Use macro to define the runtime PM operations.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/net/ethernet/renesas/ravb_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Geert Uytterhoeven Aug. 4, 2016, 1:33 p.m. UTC | #1
On Wed, Aug 3, 2016 at 3:56 PM, Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Use macro to define the runtime PM operations.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Duplicate of  commit 524c6f691b99065577b245b250efe93fb0cda5c4
Author: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Date:   Mon May 30 05:25:43 2016 +0900

    ravb: Add SET_RUNTIME_PM_OPS macro

    Use SET_RUNTIME_PM_OPS macro instead of assigning a member of
    dev_pm_ops directly.

    Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
    Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
    Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Niklas Söderlund Aug. 4, 2016, 3:28 p.m. UTC | #2
On 2016-08-04 15:33:18 +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 3, 2016 at 3:56 PM, Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > Use macro to define the runtime PM operations.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> Duplicate of  commit 524c6f691b99065577b245b250efe93fb0cda5c4
> Author: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Date:   Mon May 30 05:25:43 2016 +0900
> 
>     ravb: Add SET_RUNTIME_PM_OPS macro
> 
>     Use SET_RUNTIME_PM_OPS macro instead of assigning a member of
>     dev_pm_ops directly.
> 
>     Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>     Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>     Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>

Wops, I will drop my commit then. Thanks for pointing it out.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
diff mbox

Patch

diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index 867caf6..da8da86 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -2111,8 +2111,7 @@  static int ravb_runtime_nop(struct device *dev)
 }
 
 static const struct dev_pm_ops ravb_dev_pm_ops = {
-	.runtime_suspend = ravb_runtime_nop,
-	.runtime_resume = ravb_runtime_nop,
+	SET_RUNTIME_PM_OPS(ravb_runtime_nop, ravb_runtime_nop, NULL)
 };
 
 #define RAVB_PM_OPS (&ravb_dev_pm_ops)