| Message ID | 1470224274-31522-5-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > hw/i386/pc.c | 2 +- > kvm-all.c | 2 +- > ui/vnc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > I'm guessing these were found with a slight tweak to the Coccinelle script in 1/4? Worth checking that in, or at least leaving a comment bread-crumb? Reviewed-by: Eric Blake <eblake@redhat.com>
Eric Blake <eblake@redhat.com> writes: > On 08/03/2016 05:37 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster <armbru@redhat.com> >> --- >> hw/i386/pc.c | 2 +- >> kvm-all.c | 2 +- >> ui/vnc.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> > > I'm guessing these were found with a slight tweak to the Coccinelle > script in 1/4? Worth checking that in, or at least leaving a comment > bread-crumb? I simply examined all error_printf() calls. Only 49. If the problem persists, we may want to add a script to catch it. > Reviewed-by: Eric Blake <eblake@redhat.com> Thanks!
diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 47593b7..022dd1b 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -381,7 +381,7 @@ ISADevice *pc_find_fdc0(void) error_report("warning: multiple floppy disk controllers with " "iobase=0x3f0 have been found"); error_printf("the one being picked for CMOS setup might not reflect " - "your intent"); + "your intent\n"); } return state.floppy; diff --git a/kvm-all.c b/kvm-all.c index ef81ca5..aaa4cc6 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -2135,7 +2135,7 @@ void kvm_device_access(int fd, int group, uint64_t attr, if (err < 0) { error_report("KVM_%s_DEVICE_ATTR failed: %s", write ? "SET" : "GET", strerror(-err)); - error_printf("Group %d attr 0x%016" PRIx64, group, attr); + error_printf("Group %d attr 0x%016" PRIx64 "\n", group, attr); abort(); } } diff --git a/ui/vnc.c b/ui/vnc.c index 3ce3a5b..bad5874 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3193,7 +3193,7 @@ int vnc_display_password(const char *id, const char *password) } if (vs->auth == VNC_AUTH_NONE) { error_printf_unless_qmp("If you want use passwords please enable " - "password auth using '-vnc ${dpy},password'."); + "password auth using '-vnc ${dpy},password'.\n"); return -EINVAL; }
Signed-off-by: Markus Armbruster <armbru@redhat.com> --- hw/i386/pc.c | 2 +- kvm-all.c | 2 +- ui/vnc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)