Message ID | 20160802121047.19315-1-baolex.ni@intel.com |
---|---|
State | Rejected, archived |
Headers | show |
On Tue, Aug 02, 2016 at 08:10:47PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. I actually find using the macros significantly **decrease* the readiability of the code. A quick glance at 0644 quickly tells you what the permissions are. Parsing S_IRUSR | S_IRGRP | S_IROTH takes longer, and is more error prone. NACK. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c index 6a6c273..40877aa 100644 --- a/fs/ext4/crypto.c +++ b/fs/ext4/crypto.c @@ -42,10 +42,10 @@ static unsigned int num_prealloc_crypto_pages = 32; static unsigned int num_prealloc_crypto_ctxs = 128; -module_param(num_prealloc_crypto_pages, uint, 0444); +module_param(num_prealloc_crypto_pages, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(num_prealloc_crypto_pages, "Number of crypto pages to preallocate"); -module_param(num_prealloc_crypto_ctxs, uint, 0444); +module_param(num_prealloc_crypto_ctxs, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(num_prealloc_crypto_ctxs, "Number of crypto contexts to preallocate");