Patchwork ftl_check: drop unused verbose flag

login
register
mail settings
Submitter Mike Frysinger
Date Sept. 23, 2010, 2:33 a.m.
Message ID <1285209212-32647-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/65484/
State Accepted, archived
Headers show

Comments

Mike Frysinger - Sept. 23, 2010, 2:33 a.m.
The verbose flag isn't actually checked anywhere, so punt it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 ftl_check.c |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)
Artem Bityutskiy - Sept. 23, 2010, 1:36 p.m.
On Wed, 2010-09-22 at 22:33 -0400, Mike Frysinger wrote:
> The verbose flag isn't actually checked anywhere, so punt it.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  ftl_check.c |   13 ++++---------
>  1 files changed, 4 insertions(+), 9 deletions(-)

Pushed to mtd-utils, thanks!

Patch

diff --git a/ftl_check.c b/ftl_check.c
index f41e79a..485eaa8 100644
--- a/ftl_check.c
+++ b/ftl_check.c
@@ -79,7 +79,7 @@  static void print_size(u_int s)
 
 /*====================================================================*/
 
-static void check_partition(int fd, int verbose)
+static void check_partition(int fd)
 {
 	mtd_info_t mtd;
 	erase_unit_header_t hdr, hdr2;
@@ -180,26 +180,21 @@  static void check_partition(int fd, int verbose)
 /* Show usage information */
 void showusage(char *pname)
 {
-	fprintf(stderr, "usage: %s [-v] device\n", pname);
-	fprintf(stderr, "-v verbose messages\n");
+	fprintf(stderr, "usage: %s device\n", pname);
 }
 
 /*====================================================================*/
 
 int main(int argc, char *argv[])
 {
-	int verbose;
 	int optch, errflg, fd;
 	struct stat buf;
 
 	errflg = 0;
-	verbose = 0;
-	while ((optch = getopt(argc, argv, "vh")) != -1) {
+	while ((optch = getopt(argc, argv, "h")) != -1) {
 		switch (optch) {
 			case 'h':
 				errflg = 1; break;
-			case 'v':
-				verbose = 1; break;
 			default:
 				errflg = -1; break;
 		}
@@ -224,7 +219,7 @@  int main(int argc, char *argv[])
 		exit(EXIT_FAILURE);
 	}
 
-	check_partition(fd, verbose);
+	check_partition(fd);
 	close(fd);
 
 	exit(EXIT_SUCCESS);