diff mbox

[0817/1285] Replace numeric parameter like 0444 with macro

Message ID 20160802114918.4433-1-baolex.ni@intel.com
State Not Applicable
Headers show

Commit Message

Baole Ni Aug. 2, 2016, 11:49 a.m. UTC 
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/pci/hotplug/acpi_pcihp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c
index a5e66df..10b6d91 100644
--- a/drivers/pci/hotplug/acpi_pcihp.c
+++ b/drivers/pci/hotplug/acpi_pcihp.c
@@ -223,5 +223,5 @@  int acpi_pci_detect_ejectable(acpi_handle handle)
 }
 EXPORT_SYMBOL_GPL(acpi_pci_detect_ejectable);
 
-module_param(debug_acpi, bool, 0644);
+module_param(debug_acpi, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(debug_acpi, "Debugging mode for ACPI enabled or not");