diff mbox

[7/9] powerpc/powernv: Fix data type for @r in pnv_ioda_parse_m64_window()

Message ID 1470111037-18531-8-git-send-email-gwshan@linux.vnet.ibm.com (mailing list archive)
State Accepted
Headers show

Commit Message

Gavin Shan Aug. 2, 2016, 4:10 a.m. UTC
This fixes warning reported from sparse:

  gwshan@gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \
                             arch/powerpc/platforms/powernv/pci-ioda.o
        :
  arch/powerpc/platforms/powernv/pci-ioda.c:451:49: \
  warning: incorrect type in argument 2 (different base types)
  arch/powerpc/platforms/powernv/pci-ioda.c:451:49: \
  expected restricted __be32 const [usertype] *addr
  arch/powerpc/platforms/powernv/pci-ioda.c:451:49: \
  got unsigned int const [usertype] *
  arch/powerpc/platforms/powernv/pci-ioda.c:452:50: \
  warning: incorrect type in argument 1 (different base types)
  arch/powerpc/platforms/powernv/pci-ioda.c:452:50: \
  expected restricted __be32 const [usertype] *cell
  arch/powerpc/platforms/powernv/pci-ioda.c:452:50: \
  got unsigned int const [usertype] *
  arch/powerpc/platforms/powernv/pci-ioda.c:454:35: \
  warning: incorrect type in argument 1 (different base types)
  arch/powerpc/platforms/powernv/pci-ioda.c:454:35: \
  expected restricted __be32 const [usertype] *cell
  arch/powerpc/platforms/powernv/pci-ioda.c:454:35: \
  got unsigned int const [usertype] *[assigned] r

Fixes: 262af557dd75 ("powerpc/powernv: Enable M64 aperatus for PHB3")
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
---
 arch/powerpc/platforms/powernv/pci-ioda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Ellerman Oct. 5, 2016, 2:36 a.m. UTC | #1
On Tue, 2016-02-08 at 04:10:35 UTC, Gavin Shan wrote:
> This fixes warning reported from sparse:
> 
>   gwshan@gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \
>                              arch/powerpc/platforms/powernv/pci-ioda.o
>         :
>   arch/powerpc/platforms/powernv/pci-ioda.c:451:49: \
>   warning: incorrect type in argument 2 (different base types)
>   arch/powerpc/platforms/powernv/pci-ioda.c:451:49: \
>   expected restricted __be32 const [usertype] *addr
>   arch/powerpc/platforms/powernv/pci-ioda.c:451:49: \
>   got unsigned int const [usertype] *
>   arch/powerpc/platforms/powernv/pci-ioda.c:452:50: \
>   warning: incorrect type in argument 1 (different base types)
>   arch/powerpc/platforms/powernv/pci-ioda.c:452:50: \
>   expected restricted __be32 const [usertype] *cell
>   arch/powerpc/platforms/powernv/pci-ioda.c:452:50: \
>   got unsigned int const [usertype] *
>   arch/powerpc/platforms/powernv/pci-ioda.c:454:35: \
>   warning: incorrect type in argument 1 (different base types)
>   arch/powerpc/platforms/powernv/pci-ioda.c:454:35: \
>   expected restricted __be32 const [usertype] *cell
>   arch/powerpc/platforms/powernv/pci-ioda.c:454:35: \
>   got unsigned int const [usertype] *[assigned] r
> 
> Fixes: 262af557dd75 ("powerpc/powernv: Enable M64 aperatus for PHB3")
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/0e7736c6b806b24c693367196a076c

cheers
diff mbox

Patch

diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index 891fc4a..ac60190 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -402,7 +402,7 @@  static void __init pnv_ioda_parse_m64_window(struct pnv_phb *phb)
 	struct device_node *dn = hose->dn;
 	struct resource *res;
 	u32 m64_range[2], i;
-	const u32 *r;
+	const __be32 *r;
 	u64 pci_addr;
 
 	if (phb->type != PNV_PHB_IODA1 && phb->type != PNV_PHB_IODA2) {