[U-Boot] move: rockchip: move clock drivers into a subdirectory
diff mbox

Message ID 1469796441-11154-1-git-send-email-heiko@sntech.de
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Heiko Stuebner July 29, 2016, 12:47 p.m. UTC
With the number of Rockchip clock drivers increasing, don't clutter up
the core drivers/clk directory with them and instead move them out of
the way into a separate subdirectory.

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/clk/Makefile                    | 3 +--
 drivers/clk/rockchip/Makefile           | 8 ++++++++
 drivers/clk/{ => rockchip}/clk_rk3036.c | 0
 drivers/clk/{ => rockchip}/clk_rk3288.c | 0
 4 files changed, 9 insertions(+), 2 deletions(-)
 create mode 100644 drivers/clk/rockchip/Makefile
 rename drivers/clk/{ => rockchip}/clk_rk3036.c (100%)
 rename drivers/clk/{ => rockchip}/clk_rk3288.c (100%)

Comments

Simon Glass July 29, 2016, 1:51 p.m. UTC | #1
On 29 July 2016 at 06:47, Heiko Stuebner <heiko@sntech.de> wrote:
>
> With the number of Rockchip clock drivers increasing, don't clutter up
> the core drivers/clk directory with them and instead move them out of
> the way into a separate subdirectory.
>
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  drivers/clk/Makefile                    | 3 +--
>  drivers/clk/rockchip/Makefile           | 8 ++++++++
>  drivers/clk/{ => rockchip}/clk_rk3036.c | 0
>  drivers/clk/{ => rockchip}/clk_rk3288.c | 0
>  4 files changed, 9 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/clk/rockchip/Makefile
>  rename drivers/clk/{ => rockchip}/clk_rk3036.c (100%)
>  rename drivers/clk/{ => rockchip}/clk_rk3288.c (100%)

Isn't this a v2 patch? Anyway:

Acked-by: Simon Glass <sjg@chromium.org>
Heiko Stuebner July 29, 2016, 8:42 p.m. UTC | #2
Am Freitag, 29. Juli 2016, 07:51:14 schrieb Simon Glass:
> On 29 July 2016 at 06:47, Heiko Stuebner <heiko@sntech.de> wrote:
> > With the number of Rockchip clock drivers increasing, don't clutter up
> > the core drivers/clk directory with them and instead move them out of
> > the way into a separate subdirectory.
> > 
> > Suggested-by: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > 
> >  drivers/clk/Makefile                    | 3 +--
> >  drivers/clk/rockchip/Makefile           | 8 ++++++++
> >  drivers/clk/{ => rockchip}/clk_rk3036.c | 0
> >  drivers/clk/{ => rockchip}/clk_rk3288.c | 0
> >  4 files changed, 9 insertions(+), 2 deletions(-)
> >  create mode 100644 drivers/clk/rockchip/Makefile
> >  rename drivers/clk/{ => rockchip}/clk_rk3036.c (100%)
> >  rename drivers/clk/{ => rockchip}/clk_rk3288.c (100%)
> 
> Isn't this a v2 patch? Anyway:

it seems I was in a bit of a rush, so yeah, this could also be labeled v2, 
although the only change is the "-M" for git format-patch. When rebasing on 
top of your rockchip-master, no changes were needed


> Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass Aug. 4, 2016, 4:20 a.m. UTC | #3
On 29 July 2016 at 14:42, Heiko Stuebner <heiko@sntech.de> wrote:
> Am Freitag, 29. Juli 2016, 07:51:14 schrieb Simon Glass:
>> On 29 July 2016 at 06:47, Heiko Stuebner <heiko@sntech.de> wrote:
>> > With the number of Rockchip clock drivers increasing, don't clutter up
>> > the core drivers/clk directory with them and instead move them out of
>> > the way into a separate subdirectory.
>> >
>> > Suggested-by: Simon Glass <sjg@chromium.org>
>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> > ---
>> >
>> >  drivers/clk/Makefile                    | 3 +--
>> >  drivers/clk/rockchip/Makefile           | 8 ++++++++
>> >  drivers/clk/{ => rockchip}/clk_rk3036.c | 0
>> >  drivers/clk/{ => rockchip}/clk_rk3288.c | 0
>> >  4 files changed, 9 insertions(+), 2 deletions(-)
>> >  create mode 100644 drivers/clk/rockchip/Makefile
>> >  rename drivers/clk/{ => rockchip}/clk_rk3036.c (100%)
>> >  rename drivers/clk/{ => rockchip}/clk_rk3288.c (100%)
>>
>> Isn't this a v2 patch? Anyway:
>
> it seems I was in a bit of a rush, so yeah, this could also be labeled v2,
> although the only change is the "-M" for git format-patch. When rebasing on
> top of your rockchip-master, no changes were needed
>
>
>> Acked-by: Simon Glass <sjg@chromium.org>
>

Fixed up for rk3399 support, and:
Applied to u-boot-rockchip, thanks!

Patch
diff mbox

diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index f7a8891..3cbdd54 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -6,8 +6,7 @@ 
 #
 
 obj-$(CONFIG_CLK) += clk-uclass.o clk_fixed_rate.o
-obj-$(CONFIG_ROCKCHIP_RK3036) += clk_rk3036.o
-obj-$(CONFIG_ROCKCHIP_RK3288) += clk_rk3288.o
+obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
 obj-$(CONFIG_SANDBOX) += clk_sandbox.o
 obj-$(CONFIG_SANDBOX) += clk_sandbox_test.o
 obj-$(CONFIG_MACH_PIC32) += clk_pic32.o
diff --git a/drivers/clk/rockchip/Makefile b/drivers/clk/rockchip/Makefile
new file mode 100644
index 0000000..acfd858
--- /dev/null
+++ b/drivers/clk/rockchip/Makefile
@@ -0,0 +1,8 @@ 
+#
+# Copyright (c) 2016 Google, Inc
+#
+# SPDX-License-Identifier:      GPL-2.0+
+#
+
+obj-$(CONFIG_ROCKCHIP_RK3036) += clk_rk3036.o
+obj-$(CONFIG_ROCKCHIP_RK3288) += clk_rk3288.o
diff --git a/drivers/clk/clk_rk3036.c b/drivers/clk/rockchip/clk_rk3036.c
similarity index 100%
rename from drivers/clk/clk_rk3036.c
rename to drivers/clk/rockchip/clk_rk3036.c
diff --git a/drivers/clk/clk_rk3288.c b/drivers/clk/rockchip/clk_rk3288.c
similarity index 100%
rename from drivers/clk/clk_rk3288.c
rename to drivers/clk/rockchip/clk_rk3288.c