| Message ID | 1469656900-11582-1-git-send-email-george.mccollister@gmail.com |
|---|---|
| State | Accepted |
| Commit | 144fdbdeb1f5cbf3ee99300f7d903da373b0a90d |
| Delegated to: | Bin Meng |
| Headers | show |
On Thu, Jul 28, 2016 at 6:01 AM, George McCollister <george.mccollister@gmail.com> wrote: > Pad configuration for SERIRQ is not set to enable the SERIRQ function > on soft reset though strangely, it is on initial boot. > What does "soft reset" mean? > Signed-off-by: George McCollister <george.mccollister@gmail.com> > --- > arch/x86/dts/baytrail_som-db5800-som-6867.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Thu, Jul 28, 2016 at 1:36 AM, Bin Meng <bmeng.cn@gmail.com> wrote: > On Thu, Jul 28, 2016 at 6:01 AM, George McCollister > <george.mccollister@gmail.com> wrote: >> Pad configuration for SERIRQ is not set to enable the SERIRQ function >> on soft reset though strangely, it is on initial boot. >> > > What does "soft reset" mean? My apologies, this is misleading/incorrect. Rebooting from Linux, reset command in u-boot and even pushing the reset button on the development board all lead to this condition (address 0xfed0c560 with value of 0x2003cc80). On first boot, address 0xfed0c560 has a value of 0x2003cc81 (SERIRQ function selected). I'll update the commit message, add your reviewed-by and post a v2. > >> Signed-off-by: George McCollister <george.mccollister@gmail.com> >> --- >> arch/x86/dts/baytrail_som-db5800-som-6867.dts | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/arch/x86/dts/baytrail_som-db5800-som-6867.dts b/arch/x86/dts/baytrail_som-db5800-som-6867.dts index 64e2e52..e1d81a7 100644 --- a/arch/x86/dts/baytrail_som-db5800-som-6867.dts +++ b/arch/x86/dts/baytrail_som-db5800-som-6867.dts @@ -63,6 +63,12 @@ pad-offset = <0x270>; mode-func = <2>; }; + + /* SERIRQ */ + soc_gpio_s0_50@0 { + pad-offset = <0x560>; + mode-func = <1>; + }; }; chosen {
Pad configuration for SERIRQ is not set to enable the SERIRQ function on soft reset though strangely, it is on initial boot. Signed-off-by: George McCollister <george.mccollister@gmail.com> --- arch/x86/dts/baytrail_som-db5800-som-6867.dts | 6 ++++++ 1 file changed, 6 insertions(+)