diff mbox

ipmi: Remove hotplug from IPMI BMCs

Message ID 1469632916-28595-1-git-send-email-minyard@acm.org
State New
Headers show

Commit Message

Corey Minyard July 27, 2016, 3:21 p.m. UTC 
From: Corey Minyard <cminyard@mvista.com>

No hotplug support, make sure it doesn't happen.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
 hw/ipmi/ipmi_bmc_extern.c | 1 +
 hw/ipmi/ipmi_bmc_sim.c    | 1 +
 2 files changed, 2 insertions(+)

This is my proposed patch instead of "ipmi:free extern timer"
send by Marc-Andre.

Comments

Marc-Andre Lureau July 27, 2016, 3:31 p.m. UTC | #1 
Hi

----- Original Message -----
> From: Corey Minyard <cminyard@mvista.com>
> 
> No hotplug support, make sure it doesn't happen.
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  hw/ipmi/ipmi_bmc_extern.c | 1 +
>  hw/ipmi/ipmi_bmc_sim.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> This is my proposed patch instead of "ipmi:free extern timer"
> send by Marc-Andre.
> 
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index 157879e..ebd0d8d 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -499,6 +499,7 @@ static void ipmi_bmc_extern_class_init(ObjectClass *oc,
> void *data)
>  
>      bk->handle_command = ipmi_bmc_extern_handle_command;
>      bk->handle_reset = ipmi_bmc_extern_handle_reset;
> +    dc->hotpluggable = false;
>      dc->realize = ipmi_bmc_extern_realize;
>      dc->props = ipmi_bmc_extern_properties;
>  }
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index dc9c14c..190e169 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -1791,6 +1791,7 @@ static void ipmi_sim_class_init(ObjectClass *oc, void
> *data)
>      DeviceClass *dc = DEVICE_CLASS(oc);
>      IPMIBmcClass *bk = IPMI_BMC_CLASS(oc);
>  
> +    dc->hotpluggable = false;
>      dc->realize = ipmi_sim_realize;
>      bk->handle_command = ipmi_sim_handle_command;
>  }
> --
> 2.7.4
> 
>
diff mbox

Patch

diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
index 157879e..ebd0d8d 100644
--- a/hw/ipmi/ipmi_bmc_extern.c
+++ b/hw/ipmi/ipmi_bmc_extern.c
@@ -499,6 +499,7 @@  static void ipmi_bmc_extern_class_init(ObjectClass *oc, void *data)
 
     bk->handle_command = ipmi_bmc_extern_handle_command;
     bk->handle_reset = ipmi_bmc_extern_handle_reset;
+    dc->hotpluggable = false;
     dc->realize = ipmi_bmc_extern_realize;
     dc->props = ipmi_bmc_extern_properties;
 }
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index dc9c14c..190e169 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
@@ -1791,6 +1791,7 @@  static void ipmi_sim_class_init(ObjectClass *oc, void *data)
     DeviceClass *dc = DEVICE_CLASS(oc);
     IPMIBmcClass *bk = IPMI_BMC_CLASS(oc);
 
+    dc->hotpluggable = false;
     dc->realize = ipmi_sim_realize;
     bk->handle_command = ipmi_sim_handle_command;
 }