diff mbox

[PULL,9/9] vl: exit if a bad property value is passed to -global

Message ID 1469629761-23274-10-git-send-email-ehabkost@redhat.com
State New
Headers show

Commit Message

Eduardo Habkost July 27, 2016, 2:29 p.m. UTC 
From: Greg Kurz <groug@kaod.org>

When passing '-global driver=host-powerpc64-cpu,property=compat,value=foo'
on the command line, without this patch, we get the following warning per
device (which means many lines if the guests has many cpus):

qemu-system-ppc64: Warning: can't apply global host-powerpc64-cpu.compat=foo:
    Invalid compatibility mode "foo"

... and QEMU continues execution, ignoring the property.

With this patch, we get a single line:

qemu-system-ppc64: can't apply global host-powerpc64-cpu.compat=foo:
    Invalid compatibility mode "foo"

... and QEMU exits.

The previous behavior is kept for hotplugged devices since we don't want
QEMU to exit when doing device_add.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 vl.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/vl.c b/vl.c
index a455947..e7c2c62 100644
--- a/vl.c
+++ b/vl.c
@@ -2922,6 +2922,7 @@  static int global_init_func(void *opaque, QemuOpts *opts, Error **errp)
     g->property = qemu_opt_get(opts, "property");
     g->value    = qemu_opt_get(opts, "value");
     g->user_provided = true;
+    g->errp = &error_fatal;
     qdev_prop_register_global(g);
     return 0;
 }