From patchwork Tue Sep 21 07:19:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Meelis Roos X-Patchwork-Id: 65278 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1C7FCB6F10 for ; Tue, 21 Sep 2010 17:39:14 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756007Ab0IUHjG (ORCPT ); Tue, 21 Sep 2010 03:39:06 -0400 Received: from smtp2.it.da.ut.ee ([193.40.5.67]:59281 "EHLO smtp2.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754118Ab0IUHjG (ORCPT ); Tue, 21 Sep 2010 03:39:06 -0400 X-Greylist: delayed 1200 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Sep 2010 03:39:05 EDT Received: from math.ut.ee (math.ut.ee [193.40.36.2]) by smtp2.it.da.ut.ee (Postfix) with ESMTP id DE4E473D699 for ; Tue, 21 Sep 2010 10:19:03 +0300 (EEST) Received: by math.ut.ee (Postfix, from userid 1014) id BD774DAF81; Tue, 21 Sep 2010 10:19:03 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by math.ut.ee (Postfix) with ESMTP id A8225DAF80 for ; Tue, 21 Sep 2010 10:19:03 +0300 (EEST) Date: Tue, 21 Sep 2010 10:19:03 +0300 (EEST) From: Meelis Roos To: netdev@vger.kernel.org Subject: [PATCH] tmspci: fix tr%d in printk Message-ID: User-Agent: Alpine 1.00 (SOC 882 2007-12-20) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org tmspci driver uses dev->name before register_netdev() and so prints tr%d in initialization messages. Fix it by using dev_info. Found and tested on real hardware. Signed-off-by: Meelis Roos diff --git a/drivers/net/tokenring/tmspci.c b/drivers/net/tokenring/tmspci.c index d4c7c0c..d3e788a 100644 --- a/drivers/net/tokenring/tmspci.c +++ b/drivers/net/tokenring/tmspci.c @@ -125,18 +125,16 @@ static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic dev->irq = pci_irq_line; dev->dma = 0; - printk("%s: %s\n", dev->name, cardinfo->name); - printk("%s: IO: %#4lx IRQ: %d\n", - dev->name, dev->base_addr, dev->irq); + dev_info(&pdev->dev, "%s\n", cardinfo->name); + dev_info(&pdev->dev, " IO: %#4lx IRQ: %d\n", dev->base_addr, dev->irq); tms_pci_read_eeprom(dev); - printk("%s: Ring Station Address: %pM\n", - dev->name, dev->dev_addr); + dev_info(&pdev->dev, " Ring Station Address: %pM\n", dev->dev_addr); ret = tmsdev_init(dev, &pdev->dev); if (ret) { - printk("%s: unable to get memory for dev->priv.\n", dev->name); + dev_info(&pdev->dev, "unable to get memory for dev->priv.\n"); goto err_out_region; }