Patchwork tmspci: fix tr%d in printk

login
register
mail settings
Submitter Meelis Roos
Date Sept. 21, 2010, 7:19 a.m.
Message ID <alpine.SOC.1.00.1009211011150.28446@math.ut.ee>
Download mbox | patch
Permalink /patch/65278/
State Accepted
Delegated to: David Miller
Headers show

Comments

Meelis Roos - Sept. 21, 2010, 7:19 a.m.
tmspci driver uses dev->name before register_netdev() and so prints tr%d 
in initialization messages. Fix it by using dev_info.

Found and tested on real hardware.

Signed-off-by: Meelis Roos <mroos@linux.ee>
David Miller - Sept. 22, 2010, 1:06 a.m.
From: Meelis Roos <mroos@linux.ee>
Date: Tue, 21 Sep 2010 10:19:03 +0300 (EEST)

> tmspci driver uses dev->name before register_netdev() and so prints tr%d 
> in initialization messages. Fix it by using dev_info.
> 
> Found and tested on real hardware.
> 
> Signed-off-by: Meelis Roos <mroos@linux.ee>

Applied to net-next-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/tokenring/tmspci.c b/drivers/net/tokenring/tmspci.c
index d4c7c0c..d3e788a 100644
--- a/drivers/net/tokenring/tmspci.c
+++ b/drivers/net/tokenring/tmspci.c
@@ -125,18 +125,16 @@  static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic
 	dev->irq 	= pci_irq_line;
 	dev->dma	= 0;
 
-	printk("%s: %s\n", dev->name, cardinfo->name);
-	printk("%s:    IO: %#4lx  IRQ: %d\n",
-	       dev->name, dev->base_addr, dev->irq);
+	dev_info(&pdev->dev, "%s\n", cardinfo->name);
+	dev_info(&pdev->dev, "    IO: %#4lx  IRQ: %d\n", dev->base_addr, dev->irq);
 		
 	tms_pci_read_eeprom(dev);
 
-	printk("%s:    Ring Station Address: %pM\n",
-	       dev->name, dev->dev_addr);
+	dev_info(&pdev->dev, "    Ring Station Address: %pM\n", dev->dev_addr);
 		
 	ret = tmsdev_init(dev, &pdev->dev);
 	if (ret) {
-		printk("%s: unable to get memory for dev->priv.\n", dev->name);
+		dev_info(&pdev->dev, "unable to get memory for dev->priv.\n");
 		goto err_out_region;
 	}