Message ID | 20160725152349.A692D3FACB@swsrvapps-01.diasemi.com |
---|---|
State | Accepted, archived |
Headers | show |
On Mon, Jul 25, 2016 at 04:20:54PM +0100, Steve Twiss wrote: > From: Steve Twiss <stwiss.opensource@diasemi.com> > > Hi Mark, Drop this from the commit msg. > > Buck and LDO binding name changes. > > The binding names for the regulators have been changed to match the current > expectation from existing device tree source files. > > This fix rectifies the disparity between what currently exists in some > .dts[i] board files and what is listed in this binding document. This > change re-aligns those differences and also brings the binding document > in-line with the expectations of the product datasheet from Dialog > Semiconductor. > > Bucks and LDOs now follow the expected notation: > { buck1, buck2, buck3, buck4 } > { ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10 } > > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> > > --- > This patch applies against linux-next and v4.7 > > Hi, > > Several device tree source files use a regulator naming scheme different to > that found in the binding text document. Since those have been used > already, I would like ensure to the binding document follows those existing > DT file naming conventions. > > Please refer to the files containing da9052/53 references: > - ./arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi > - ./arch/arm/boot/dts/imx53-qsb.dts > > Those board files use the naming convention: > { buck1, buck2, buck3, buck4 } > { ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10 } > > Instead of the existing suggestion in the device tree binding file: > { buck0, buck1, buck2, buck3 } > { ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10, ldo11, ldo12, ldo13 } > > The binding file regulator names (as it stands) does not reflect any > real-world uses I can find. This change would bring it in-line with > currect expectations from existing DTS files and make it similar enough to > the product datasheets to be "less confusing" than it currently is. > > Regards, > Steve > > See reference: > https://lkml.org/lkml/2016/7/25/197 > > > .../devicetree/bindings/mfd/da9052-i2c.txt | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) Otherwise, Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 27, 2016 at 9:51 AM, Rob Herring <robh@kernel.org> wrote: > On Mon, Jul 25, 2016 at 04:20:54PM +0100, Steve Twiss wrote: >> From: Steve Twiss <stwiss.opensource@diasemi.com> >> >> Hi Mark, > > Drop this from the commit msg. > >> >> Buck and LDO binding name changes. >> >> The binding names for the regulators have been changed to match the current >> expectation from existing device tree source files. >> >> This fix rectifies the disparity between what currently exists in some >> .dts[i] board files and what is listed in this binding document. This >> change re-aligns those differences and also brings the binding document >> in-line with the expectations of the product datasheet from Dialog >> Semiconductor. >> >> Bucks and LDOs now follow the expected notation: >> { buck1, buck2, buck3, buck4 } >> { ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10 } >> >> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> >> >> --- >> This patch applies against linux-next and v4.7 >> >> Hi, >> >> Several device tree source files use a regulator naming scheme different to >> that found in the binding text document. Since those have been used >> already, I would like ensure to the binding document follows those existing >> DT file naming conventions. >> >> Please refer to the files containing da9052/53 references: >> - ./arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi >> - ./arch/arm/boot/dts/imx53-qsb.dts >> >> Those board files use the naming convention: >> { buck1, buck2, buck3, buck4 } >> { ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10 } >> >> Instead of the existing suggestion in the device tree binding file: >> { buck0, buck1, buck2, buck3 } >> { ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10, ldo11, ldo12, ldo13 } >> >> The binding file regulator names (as it stands) does not reflect any >> real-world uses I can find. This change would bring it in-line with >> currect expectations from existing DTS files and make it similar enough to >> the product datasheets to be "less confusing" than it currently is. >> >> Regards, >> Steve >> >> See reference: >> https://lkml.org/lkml/2016/7/25/197 >> >> >> .../devicetree/bindings/mfd/da9052-i2c.txt | 22 +++++++++++----------- >> 1 file changed, 11 insertions(+), 11 deletions(-) > > Otherwise, > > Acked-by: Rob Herring <robh@kernel.org> As this is just a doc change, I've fixed up the commit msg and applied. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt index 1857f4a..9554292 100644 --- a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt +++ b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt @@ -8,10 +8,13 @@ Sub-nodes: - regulators : Contain the regulator nodes. The DA9052/53 regulators are bound using their names as listed below: - buck0 : regulator BUCK0 - buck1 : regulator BUCK1 - buck2 : regulator BUCK2 - buck3 : regulator BUCK3 + buck1 : regulator BUCK CORE + buck2 : regulator BUCK PRO + buck3 : regulator BUCK MEM + buck4 : regulator BUCK PERI + ldo1 : regulator LDO1 + ldo2 : regulator LDO2 + ldo3 : regulator LDO3 ldo4 : regulator LDO4 ldo5 : regulator LDO5 ldo6 : regulator LDO6 @@ -19,9 +22,6 @@ Sub-nodes: ldo8 : regulator LDO8 ldo9 : regulator LDO9 ldo10 : regulator LDO10 - ldo11 : regulator LDO11 - ldo12 : regulator LDO12 - ldo13 : regulator LDO13 The bindings details of individual regulator device can be found in: Documentation/devicetree/bindings/regulator/regulator.txt @@ -36,22 +36,22 @@ i2c@63fc8000 { /* I2C1 */ reg = <0x48>; regulators { - buck0 { + buck1 { regulator-min-microvolt = <500000>; regulator-max-microvolt = <2075000>; }; - buck1 { + buck2 { regulator-min-microvolt = <500000>; regulator-max-microvolt = <2075000>; }; - buck2 { + buck3 { regulator-min-microvolt = <925000>; regulator-max-microvolt = <2500000>; }; - buck3 { + buck4 { regulator-min-microvolt = <925000>; regulator-max-microvolt = <2500000>; };