Message ID | 20160725131023.30656-3-vigneshr@ti.com |
---|---|
State | Superseded |
Delegated to: | Tom Rini |
Headers | show |
On Mon, Jul 25, 2016 at 06:40:21PM +0530, Vignesh R wrote: > On DRA7, pcf chip present at address 0x21 on i2c1, is used to > switch between cpsw slave0 and slave1. Hence, enable PCF > driver for the same. > > Signed-off-by: Vignesh R <vigneshr@ti.com> > --- > include/configs/dra7xx_evm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h > index 0d51aeb86909..4ad8beaf2f75 100644 > --- a/include/configs/dra7xx_evm.h > +++ b/include/configs/dra7xx_evm.h > @@ -328,4 +328,9 @@ > #define CONFIG_EEPROM_CHIP_ADDRESS 0x50 > #define CONFIG_EEPROM_BUS_ADDRESS 0 > > +/* PCF Support */ > +#ifndef CONFIG_SPL_BUILD > +#define CONFIG_PCF8575_GPIO > +#endif We need to invert the logic and undef on SPL, and pick this up normally via Kconfig.
On Monday 25 July 2016 07:08 PM, Tom Rini wrote: > On Mon, Jul 25, 2016 at 06:40:21PM +0530, Vignesh R wrote: > >> On DRA7, pcf chip present at address 0x21 on i2c1, is used to >> switch between cpsw slave0 and slave1. Hence, enable PCF >> driver for the same. >> >> Signed-off-by: Vignesh R <vigneshr@ti.com> >> --- >> include/configs/dra7xx_evm.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h >> index 0d51aeb86909..4ad8beaf2f75 100644 >> --- a/include/configs/dra7xx_evm.h >> +++ b/include/configs/dra7xx_evm.h >> @@ -328,4 +328,9 @@ >> #define CONFIG_EEPROM_CHIP_ADDRESS 0x50 >> #define CONFIG_EEPROM_BUS_ADDRESS 0 >> >> +/* PCF Support */ >> +#ifndef CONFIG_SPL_BUILD >> +#define CONFIG_PCF8575_GPIO >> +#endif > > We need to invert the logic and undef on SPL, and pick this up normally > via Kconfig. > I tried that initially but, the logic does not seem to work. Since, the driver is DM only driver, undef'ing CONFIG_PCF8575_GPIO on CONFIG_SPL_BUILD does seem to take any effect, the driver is still being compiled for SPL build and results in compile time errors. It seems that undef in include/configs/* file does not seem to take effect in Makefile, but only takes effect in the code. Any idea what am I missing?
Hi Vignesh, On 26 July 2016 at 00:33, Vignesh R <vigneshr@ti.com> wrote: > > > On Monday 25 July 2016 07:08 PM, Tom Rini wrote: >> On Mon, Jul 25, 2016 at 06:40:21PM +0530, Vignesh R wrote: >> >>> On DRA7, pcf chip present at address 0x21 on i2c1, is used to >>> switch between cpsw slave0 and slave1. Hence, enable PCF >>> driver for the same. >>> >>> Signed-off-by: Vignesh R <vigneshr@ti.com> >>> --- >>> include/configs/dra7xx_evm.h | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h >>> index 0d51aeb86909..4ad8beaf2f75 100644 >>> --- a/include/configs/dra7xx_evm.h >>> +++ b/include/configs/dra7xx_evm.h >>> @@ -328,4 +328,9 @@ >>> #define CONFIG_EEPROM_CHIP_ADDRESS 0x50 >>> #define CONFIG_EEPROM_BUS_ADDRESS 0 >>> >>> +/* PCF Support */ >>> +#ifndef CONFIG_SPL_BUILD >>> +#define CONFIG_PCF8575_GPIO >>> +#endif >> >> We need to invert the logic and undef on SPL, and pick this up normally >> via Kconfig. >> > > I tried that initially but, the logic does not seem to work. Since, the > driver is DM only driver, undef'ing CONFIG_PCF8575_GPIO on > CONFIG_SPL_BUILD does seem to take any effect, the driver is still being > compiled for SPL build and results in compile time errors. It seems that > undef in include/configs/* file does not seem to take effect in > Makefile, but only takes effect in the code. Any idea what am I missing? Can you have CONFIG_PCF8575_GPIO and CONFIG_SPL_PCF8575_GPIO? Then obj-CONFIG_$(SPL_)PCF8575_GPIO += ... Regards, Simon
diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h index 0d51aeb86909..4ad8beaf2f75 100644 --- a/include/configs/dra7xx_evm.h +++ b/include/configs/dra7xx_evm.h @@ -328,4 +328,9 @@ #define CONFIG_EEPROM_CHIP_ADDRESS 0x50 #define CONFIG_EEPROM_BUS_ADDRESS 0 +/* PCF Support */ +#ifndef CONFIG_SPL_BUILD +#define CONFIG_PCF8575_GPIO +#endif + #endif /* __CONFIG_DRA7XX_EVM_H */
On DRA7, pcf chip present at address 0x21 on i2c1, is used to switch between cpsw slave0 and slave1. Hence, enable PCF driver for the same. Signed-off-by: Vignesh R <vigneshr@ti.com> --- include/configs/dra7xx_evm.h | 5 +++++ 1 file changed, 5 insertions(+)