Message ID | 1469430329-8737-1-git-send-email-weiyj.lk@gmail.com |
---|---|
State | Rejected |
Headers | show
Return-Path: <rtc-linux+bncBCAP3QEPQIDBBP7U226AKGQEQT4SUDQ@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yw0-x23d.google.com (mail-yw0-x23d.google.com [IPv6:2607:f8b0:4002:c05::23d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ryXMj67GZz9t1T for <incoming@patchwork.ozlabs.org>; Mon, 25 Jul 2016 17:05:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=m6QTl+Rs; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=g2zk2wzk; dkim-atps=neutral Received: by mail-yw0-x23d.google.com with SMTP id u134sf27736997ywg.1 for <incoming@patchwork.ozlabs.org>; Mon, 25 Jul 2016 00:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=6vsX5/kEYAjM1eS5/oCQknoyOqw2pAhgFwLbOPuye+I=; b=m6QTl+RsjwVQQFQQYnZ+oMoFMGHChs9RKMvlJI/Y2+0zQwBvpOrea+qVjFjxSZOYh1 PqD09CzuWMQWM+AUBHRVg2h1yiatAIe/OzKhf5iI+eQcZwLxetKlj/BW5yhC6BQeXsT0 t1nWAm+Nl+5oS2Kpq/V8v7BkKlZieh44Cp5+pH1RzM8uGg43cpLLGf6Rh/8qSuFLd3gU 8ZRRHo4yCh4Ngv2mZqKPZPNVBAHM+MVH8nQrula4PiAnxSzj3pDtD+HOyuGzBQooEX1+ VRPCVgvAq1EHhP5Aydlznb833m6cON6BJQWNMzuf4D2PzhzwSCHJBjd9GRL1fXwWtxzJ oD6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=6vsX5/kEYAjM1eS5/oCQknoyOqw2pAhgFwLbOPuye+I=; b=g2zk2wzkUDPvuPmX708Ii1QSQHjqJW06erQ7FbPw3sRLVardFsaPY/8C+c3kTO5a7Q 8n14gdeYO6voLJV1wQZGDuKdl1PDx9Bdmdvl40DjgBROoUPjUxzHLuk66eHIrNdmF1iu tQ1f5sgD3zYGtxPFOPMlI5NZlDdAIqhFwWoenY4izhs3VngedKosJXYbaQ4h/DVZwL5/ xXwwiOQfjbU5x41dLms5uaeATC2BZ5TOEwq5nygFZJlUTZmvMvw9DaMjF0nFTEyDPbGU /yoVdE38tjOo/yq29ePkeOM/gB6EPIn10BUeoj9BND/0TbZWVi/LSH8ozWzxNFLeRVx6 6+bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=6vsX5/kEYAjM1eS5/oCQknoyOqw2pAhgFwLbOPuye+I=; b=AXN0tcn8W5N5znUUcHrSjnKMeW78U4ivHoIcG7ZUqk3549Y+50xxaoz1SYdLqKrpEt j/faNs/HrSnGnD05TpkHaUMjtNKUCoLdjDz67my9+Mvx7E0rIpyoAk+zYk2vzHZB+zgl 9LOP6kdVk9fifM106REL6AflQ6bUfTZctv1tDaVhfKTSEa5cHlRdAdmhCHN20rUgpMcJ BwNevUhtn0pmebz1irz2RlFJnsNG3ziThvhamn0JXE0f3jS0CeH1lce9t7+WgNaYA3mZ 9PnTV8qlFTa5lXj5b4ZFQJAdfuQ1aBj7Ibr8D2dRAXyuSAAVL2ghag9lDEGbG702liYJ 3kkQ== Sender: rtc-linux@googlegroups.com X-Gm-Message-State: AEkoouvvek/fX4GFTDI9AiFdUh3TTVVoBk9gsW8lXgRo7wgzC4e6Js+Io4yyQau7asfuYQ== X-Received: by 10.157.46.169 with SMTP id w38mr748330ota.15.1469430336035; Mon, 25 Jul 2016 00:05:36 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.157.11.77 with SMTP id p13ls7437477otd.47.gmail; Mon, 25 Jul 2016 00:05:35 -0700 (PDT) X-Received: by 10.31.135.203 with SMTP id j194mr1807939vkd.1.1469430335776; Mon, 25 Jul 2016 00:05:35 -0700 (PDT) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com. [2607:f8b0:400e:c00::241]) by gmr-mx.google.com with ESMTPS id z4si3267980pam.0.2016.07.25.00.05.35 for <rtc-linux@googlegroups.com> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jul 2016 00:05:35 -0700 (PDT) Received-SPF: pass (google.com: domain of weiyj.lk@gmail.com designates 2607:f8b0:400e:c00::241 as permitted sender) client-ip=2607:f8b0:400e:c00::241; Received: by mail-pf0-x241.google.com with SMTP id i6so11420863pfe.0 for <rtc-linux@googlegroups.com>; Mon, 25 Jul 2016 00:05:35 -0700 (PDT) X-Received: by 10.98.30.133 with SMTP id e127mr27289528pfe.104.1469430334634; Mon, 25 Jul 2016 00:05:34 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id p75sm37135130pfa.71.2016.07.25.00.05.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jul 2016 00:05:34 -0700 (PDT) From: Wei Yongjun <weiyj.lk@gmail.com> To: Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@free-electrons.com> Cc: Wei Yongjun <weiyj.lk@gmail.com>, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] [PATCH -next] rtc: asm9260: Fix missing spin_lock_init() Date: Mon, 25 Jul 2016 07:05:29 +0000 Message-Id: <1469430329-8737-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Original-Sender: weiyj.lk@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com; spf=pass (google.com: domain of weiyj.lk@gmail.com designates 2607:f8b0:400e:c00::241 as permitted sender) smtp.mailfrom=weiyj.lk@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: <https://groups.google.com/group/rtc-linux/post>, <mailto:rtc-linux@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <https://groups.google.com/group/rtc-linux List-Subscribe: <https://groups.google.com/group/rtc-linux/subscribe>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com>, <https://groups.google.com/group/rtc-linux/subscribe> |
diff --git a/drivers/rtc/rtc-asm9260.c b/drivers/rtc/rtc-asm9260.c index 355fdb9..5ddcc91 100644 --- a/drivers/rtc/rtc-asm9260.c +++ b/drivers/rtc/rtc-asm9260.c @@ -267,6 +267,7 @@ static int asm9260_rtc_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; + spin_lock_init(&priv->lock); priv->dev = &pdev->dev; platform_set_drvdata(pdev, priv);
The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> --- drivers/rtc/rtc-asm9260.c | 1 + 1 file changed, 1 insertion(+)