Patchwork [ARM] Fix PR 45726: invalid instruction on arm9tdmi.

login
register
mail settings
Submitter Richard Earnshaw
Date Sept. 20, 2010, 3:35 p.m.
Message ID <1284996945.13878.28.camel@e102346-lin.cambridge.arm.com>
Download mbox | patch
Permalink /patch/65218/
State New
Headers show

Comments

Richard Earnshaw - Sept. 20, 2010, 3:35 p.m.
PR 45726 is a wrong code bug on ARM where we accidentally emit an
instruction to perform a bitfield-insert-immediate on machines with no
support for MOVT.  The patch is pretty trivial, we just disable the
pattern on machines without MOVT.

Committed to 4.5 branch and trunk.

R.

2010-09-20  Rafael Carre   <rafael.carre@gmail.com>

	PR target/45726
	* arm.md (arm_movtas_ze): Only enable on machine with MOVT.

Patch

Index: arm.md
===================================================================
--- arm.md	(revision 164433)
+++ arm.md	(working copy)
@@ -11191,7 +11191,7 @@  (define_insn "*arm_movtas_ze" 
                    (const_int 16)
                    (const_int 16))
         (match_operand:SI 1 "const_int_operand" ""))]
-  "TARGET_32BIT"
+  "arm_arch_thumb2"
   "movt%?\t%0, %c1"
  [(set_attr "predicable" "yes")
    (set_attr "length" "4")]