Message ID | 1469200138-56632-1-git-send-email-Vincent.Riera@imgtec.com |
---|---|
State | Accepted |
Headers | show |
Hello, On Fri, 22 Jul 2016 16:08:58 +0100, Vicente Olivert Riera wrote: > +# Startup script for ser2net > +# > + > +[ -f /usr/sbin/ser2net ] || exit 0 This check is pretty useless: the init script is installed along with the ser2net binary. So I've removed this check. > + > +start() { > + echo -n "Starting ser2net: " We normally use printf instead of echo -n. Also, starting the daemon fails if there's no config file, with no error message whatsoever. So I've added a check here to see if there's a configuration file or not, and show a clear message where there's none. > + start-stop-daemon -S -q --exec /usr/sbin/ser2net -- -P /var/run/ser2net.pid > + [ $? = 0 ] && echo "OK" || echo "FAIL" > +} > + > +stop() { > + echo -n "Shutting down ser2net " > + start-stop-daemon -K -q -p /var/run/ser2net.pid > + [ $? = 0 ] && echo "OK" || echo "FAIL" > +} > + > +restart() { > + stop > + start Indentation here was done with one tab, while it was done with 4 spaces above. So I've changed that to 4 spaces everywhere, since it seems to be what we do in most init scripts. Applied with those changes. Thanks! Thomas
diff --git a/package/ser2net/S50ser2net b/package/ser2net/S50ser2net new file mode 100644 index 0000000..d527485 --- /dev/null +++ b/package/ser2net/S50ser2net @@ -0,0 +1,40 @@ +#!/bin/sh +# +# Startup script for ser2net +# + +[ -f /usr/sbin/ser2net ] || exit 0 + +start() { + echo -n "Starting ser2net: " + start-stop-daemon -S -q --exec /usr/sbin/ser2net -- -P /var/run/ser2net.pid + [ $? = 0 ] && echo "OK" || echo "FAIL" +} + +stop() { + echo -n "Shutting down ser2net " + start-stop-daemon -K -q -p /var/run/ser2net.pid + [ $? = 0 ] && echo "OK" || echo "FAIL" +} + +restart() { + stop + start +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + restart + ;; + *) + echo "Usage: ser2net {start|stop|restart}" + exit 1 +esac + +exit $? diff --git a/package/ser2net/ser2net.mk b/package/ser2net/ser2net.mk index ac64c3d..85b23ae 100644 --- a/package/ser2net/ser2net.mk +++ b/package/ser2net/ser2net.mk @@ -9,4 +9,9 @@ SER2NET_SITE = http://downloads.sourceforge.net/project/ser2net/ser2net SER2NET_LICENSE = GPLv2+ SER2NET_LICENSE_FILES = COPYING +define SER2NET_INSTALL_INIT_SYSV + $(INSTALL) -D -m 755 package/ser2net/S50ser2net \ + $(TARGET_DIR)/etc/init.d/S50ser2net +endef + $(eval $(autotools-package))
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- package/ser2net/S50ser2net | 40 ++++++++++++++++++++++++++++++++++++++++ package/ser2net/ser2net.mk | 5 +++++ 2 files changed, 45 insertions(+) create mode 100644 package/ser2net/S50ser2net