diff mbox

ARM: no need to select SMP_ON_UP explicitly

Message ID 1469199369-25746-1-git-send-email-vladimir.murzin@arm.com
State New
Headers show

Commit Message

Vladimir Murzin July 22, 2016, 2:56 p.m. UTC
SMP_ON_UP is already defaulted to "y" and has all dependencies expressed
- no need to select it per platform level

Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
---

This time sent to LAKML

 arch/arm/mach-imx/Kconfig      |    3 ---
 arch/arm/mach-realview/Kconfig |    1 -
 2 files changed, 4 deletions(-)

Comments

Shawn Guo Aug. 9, 2016, 8:44 a.m. UTC | #1
On Fri, Jul 22, 2016 at 03:56:09PM +0100, Vladimir Murzin wrote:
> SMP_ON_UP is already defaulted to "y" and has all dependencies expressed
> - no need to select it per platform level
> 
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
> 
> This time sent to LAKML
> 
>  arch/arm/mach-imx/Kconfig      |    3 ---
>  arch/arm/mach-realview/Kconfig |    1 -

I cannot take mach-realview changes.  I think you need to ether split
the changes, or ask arm-soc folks to apply.  In case of the latter, here
is my ACK:

Acked-by: Shawn Guo <shawnguo@kernel.org>

>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index dd905b9..cfb1120 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -92,7 +92,6 @@ config SOC_IMX31
>  	select CPU_V6
>  	select IMX_HAVE_PLATFORM_MXC_RNGA
>  	select MXC_AVIC
> -	select SMP_ON_UP if SMP
>  
>  config SOC_IMX35
>  	bool
> @@ -100,7 +99,6 @@ config SOC_IMX35
>  	select HAVE_EPIT
>  	select MXC_AVIC
>  	select PINCTRL_IMX35
> -	select SMP_ON_UP if SMP
>  
>  if ARCH_MULTI_V4T
>  
> @@ -589,7 +587,6 @@ config SOC_VF610
>  	select ARM_GIC if ARCH_MULTI_V7
>  	select PINCTRL_VF610
>  	select PL310_ERRATA_769419 if CACHE_L2X0
> -	select SMP_ON_UP if SMP
>  
>  	help
>  	  This enables support for Freescale Vybrid VF610 processor.
> diff --git a/arch/arm/mach-realview/Kconfig b/arch/arm/mach-realview/Kconfig
> index 70ab4a2..739800e 100644
> --- a/arch/arm/mach-realview/Kconfig
> +++ b/arch/arm/mach-realview/Kconfig
> @@ -24,7 +24,6 @@ config REALVIEW_DT
>  	select POWER_RESET
>  	select POWER_RESET_VERSATILE
>  	select POWER_SUPPLY
> -	select SMP_ON_UP if SMP
>  	select SOC_REALVIEW
>  	select USE_OF
>  	help
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Vladimir Murzin Aug. 10, 2016, 8:29 a.m. UTC | #2
On 09/08/16 09:44, Shawn Guo wrote:
> On Fri, Jul 22, 2016 at 03:56:09PM +0100, Vladimir Murzin wrote:
>> SMP_ON_UP is already defaulted to "y" and has all dependencies expressed
>> - no need to select it per platform level
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>>
>> This time sent to LAKML
>>
>>  arch/arm/mach-imx/Kconfig      |    3 ---
>>  arch/arm/mach-realview/Kconfig |    1 -
> 
> I cannot take mach-realview changes.  I think you need to ether split
> the changes, or ask arm-soc folks to apply.  In case of the latter, here
> is my ACK:
> 
> Acked-by: Shawn Guo <shawnguo@kernel.org>

Thanks!

RealView is not mentioned under MAINTAINERS, so it'd be easier if
arm-soc team pick this patch.

Arnd, what is your preference?

Cheers
Vladimir

> 
>>  2 files changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index dd905b9..cfb1120 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -92,7 +92,6 @@ config SOC_IMX31
>>  	select CPU_V6
>>  	select IMX_HAVE_PLATFORM_MXC_RNGA
>>  	select MXC_AVIC
>> -	select SMP_ON_UP if SMP
>>  
>>  config SOC_IMX35
>>  	bool
>> @@ -100,7 +99,6 @@ config SOC_IMX35
>>  	select HAVE_EPIT
>>  	select MXC_AVIC
>>  	select PINCTRL_IMX35
>> -	select SMP_ON_UP if SMP
>>  
>>  if ARCH_MULTI_V4T
>>  
>> @@ -589,7 +587,6 @@ config SOC_VF610
>>  	select ARM_GIC if ARCH_MULTI_V7
>>  	select PINCTRL_VF610
>>  	select PL310_ERRATA_769419 if CACHE_L2X0
>> -	select SMP_ON_UP if SMP
>>  
>>  	help
>>  	  This enables support for Freescale Vybrid VF610 processor.
>> diff --git a/arch/arm/mach-realview/Kconfig b/arch/arm/mach-realview/Kconfig
>> index 70ab4a2..739800e 100644
>> --- a/arch/arm/mach-realview/Kconfig
>> +++ b/arch/arm/mach-realview/Kconfig
>> @@ -24,7 +24,6 @@ config REALVIEW_DT
>>  	select POWER_RESET
>>  	select POWER_RESET_VERSATILE
>>  	select POWER_SUPPLY
>> -	select SMP_ON_UP if SMP
>>  	select SOC_REALVIEW
>>  	select USE_OF
>>  	help
>> -- 
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
>
Arnd Bergmann Aug. 10, 2016, 8:55 a.m. UTC | #3
On Wednesday, August 10, 2016 9:29:11 AM CEST Vladimir Murzin wrote:
> On 09/08/16 09:44, Shawn Guo wrote:
> > On Fri, Jul 22, 2016 at 03:56:09PM +0100, Vladimir Murzin wrote:
> >> SMP_ON_UP is already defaulted to "y" and has all dependencies expressed
> >> - no need to select it per platform level
> >>
> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> >> ---
> >>
> >> This time sent to LAKML
> >>
> >>  arch/arm/mach-imx/Kconfig      |    3 ---
> >>  arch/arm/mach-realview/Kconfig |    1 -
> > 
> > I cannot take mach-realview changes.  I think you need to ether split
> > the changes, or ask arm-soc folks to apply.  In case of the latter, here
> > is my ACK:
> > 
> > Acked-by: Shawn Guo <shawnguo@kernel.org>
> 
> Thanks!
> 
> RealView is not mentioned under MAINTAINERS, so it'd be easier if
> arm-soc team pick this patch.
> 
> Arnd, what is your preference?

Linus Walleij is the person that has sent most patches for realview,
so I'll let him decide. We can pick it up directly, or he can
aggregate it with other patches that he might have.

	Arnd
Linus Walleij Aug. 10, 2016, 12:25 p.m. UTC | #4
On Wed, Aug 10, 2016 at 10:55 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday, August 10, 2016 9:29:11 AM CEST Vladimir Murzin wrote:
>> On 09/08/16 09:44, Shawn Guo wrote:
>> > On Fri, Jul 22, 2016 at 03:56:09PM +0100, Vladimir Murzin wrote:
>> >> SMP_ON_UP is already defaulted to "y" and has all dependencies expressed
>> >> - no need to select it per platform level
>> >>
>> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> >> ---
>> >>
>> >> This time sent to LAKML
>> >>
>> >>  arch/arm/mach-imx/Kconfig      |    3 ---
>> >>  arch/arm/mach-realview/Kconfig |    1 -
>> >
>> > I cannot take mach-realview changes.  I think you need to ether split
>> > the changes, or ask arm-soc folks to apply.  In case of the latter, here
>> > is my ACK:
>> >
>> > Acked-by: Shawn Guo <shawnguo@kernel.org>
>>
>> Thanks!
>>
>> RealView is not mentioned under MAINTAINERS, so it'd be easier if
>> arm-soc team pick this patch.
>>
>> Arnd, what is your preference?
>
> Linus Walleij is the person that has sent most patches for realview,
> so I'll let him decide. We can pick it up directly, or he can
> aggregate it with other patches that he might have.

I have queued this with a bunch of other RealView clean-ups and board
file removal patches and will send a pull request for it shortly.

Yours,
Linus Walleij
Vladimir Murzin Aug. 10, 2016, 12:56 p.m. UTC | #5
On 10/08/16 13:25, Linus Walleij wrote:
> On Wed, Aug 10, 2016 at 10:55 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Wednesday, August 10, 2016 9:29:11 AM CEST Vladimir Murzin wrote:
>>> On 09/08/16 09:44, Shawn Guo wrote:
>>>> On Fri, Jul 22, 2016 at 03:56:09PM +0100, Vladimir Murzin wrote:
>>>>> SMP_ON_UP is already defaulted to "y" and has all dependencies expressed
>>>>> - no need to select it per platform level
>>>>>
>>>>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>>>>> ---
>>>>>
>>>>> This time sent to LAKML
>>>>>
>>>>>  arch/arm/mach-imx/Kconfig      |    3 ---
>>>>>  arch/arm/mach-realview/Kconfig |    1 -
>>>>
>>>> I cannot take mach-realview changes.  I think you need to ether split
>>>> the changes, or ask arm-soc folks to apply.  In case of the latter, here
>>>> is my ACK:
>>>>
>>>> Acked-by: Shawn Guo <shawnguo@kernel.org>
>>>
>>> Thanks!
>>>
>>> RealView is not mentioned under MAINTAINERS, so it'd be easier if
>>> arm-soc team pick this patch.
>>>
>>> Arnd, what is your preference?
>>
>> Linus Walleij is the person that has sent most patches for realview,
>> so I'll let him decide. We can pick it up directly, or he can
>> aggregate it with other patches that he might have.
> 
> I have queued this with a bunch of other RealView clean-ups and board
> file removal patches and will send a pull request for it shortly.

Thanks!

Shawn, since Linus picked up realview part only do you want me resubmit
remaining imx part?

Cheers
Vladimir

> 
> Yours,
> Linus Walleij
> 
>
Shawn Guo Aug. 15, 2016, 1:22 p.m. UTC | #6
On Wed, Aug 10, 2016 at 01:56:06PM +0100, Vladimir Murzin wrote:
> Shawn, since Linus picked up realview part only do you want me resubmit
> remaining imx part?

I just applied the IMX part, thanks.
diff mbox

Patch

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index dd905b9..cfb1120 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -92,7 +92,6 @@  config SOC_IMX31
 	select CPU_V6
 	select IMX_HAVE_PLATFORM_MXC_RNGA
 	select MXC_AVIC
-	select SMP_ON_UP if SMP
 
 config SOC_IMX35
 	bool
@@ -100,7 +99,6 @@  config SOC_IMX35
 	select HAVE_EPIT
 	select MXC_AVIC
 	select PINCTRL_IMX35
-	select SMP_ON_UP if SMP
 
 if ARCH_MULTI_V4T
 
@@ -589,7 +587,6 @@  config SOC_VF610
 	select ARM_GIC if ARCH_MULTI_V7
 	select PINCTRL_VF610
 	select PL310_ERRATA_769419 if CACHE_L2X0
-	select SMP_ON_UP if SMP
 
 	help
 	  This enables support for Freescale Vybrid VF610 processor.
diff --git a/arch/arm/mach-realview/Kconfig b/arch/arm/mach-realview/Kconfig
index 70ab4a2..739800e 100644
--- a/arch/arm/mach-realview/Kconfig
+++ b/arch/arm/mach-realview/Kconfig
@@ -24,7 +24,6 @@  config REALVIEW_DT
 	select POWER_RESET
 	select POWER_RESET_VERSATILE
 	select POWER_SUPPLY
-	select SMP_ON_UP if SMP
 	select SOC_REALVIEW
 	select USE_OF
 	help