diff mbox

[U-Boot,v2,3/3] CONFIG_EFI_LOADER breaks rock2 kernel loading

Message ID 1469198413-1157-4-git-send-email-apatterson@sightlogix.com
State Deferred
Delegated to: Tom Rini
Headers show

Commit Message

Sandy Patterson July 22, 2016, 2:40 p.m. UTC
The problem seems to be invalidate_icache_all() inside the runtime.
This patch just disables EFI_LOADER for rock2 board.

Signed-off-by: Sandy Patterson <apatterson@sightlogix.com>
---

 configs/rock2_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass Aug. 8, 2016, 9:43 p.m. UTC | #1
Hi Sandy,

On 22 July 2016 at 08:40, Sandy Patterson <apatterson@sightlogix.com> wrote:
> The problem seems to be invalidate_icache_all() inside the runtime.
> This patch just disables EFI_LOADER for rock2 board.
>
> Signed-off-by: Sandy Patterson <apatterson@sightlogix.com>
> ---
>
>  configs/rock2_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Can you please give me an update on these patches? Did you discover
the root cause? What patches do you think need to be applied for this
release. I'd like to get a few more test reports too if possible.

Regards,
Simon
Xu Ziyuan Aug. 9, 2016, 12:50 a.m. UTC | #2
Hi Simon,

I think you can drop this patch due to it fixes by a78cd86 - ARM: Rework 
and correct barrier which Tom had merge it into u-boot/master.

On 2016年08月09日 05:43, Simon Glass wrote:
> Hi Sandy,
>
> On 22 July 2016 at 08:40, Sandy Patterson <apatterson@sightlogix.com> wrote:
>> The problem seems to be invalidate_icache_all() inside the runtime.
>> This patch just disables EFI_LOADER for rock2 board.
>>
>> Signed-off-by: Sandy Patterson <apatterson@sightlogix.com>
>> ---
>>
>>   configs/rock2_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
> Can you please give me an update on these patches? Did you discover
> the root cause? What patches do you think need to be applied for this
> release. I'd like to get a few more test reports too if possible.
>
> Regards,
> Simon
>
>
>
Sandy Patterson Aug. 9, 2016, 1:35 a.m. UTC | #3
I also found that once the barrier stuff was in, the EFI_LOADER change was
unnecessary.

On Mon, Aug 8, 2016 at 8:50 PM, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:

> Hi Simon,
>
> I think you can drop this patch due to it fixes by a78cd86 - ARM: Rework
> and correct barrier which Tom had merge it into u-boot/master.
>
>
> On 2016年08月09日 05:43, Simon Glass wrote:
>
>> Hi Sandy,
>>
>> On 22 July 2016 at 08:40, Sandy Patterson <apatterson@sightlogix.com>
>> wrote:
>>
>>> The problem seems to be invalidate_icache_all() inside the runtime.
>>> This patch just disables EFI_LOADER for rock2 board.
>>>
>>> Signed-off-by: Sandy Patterson <apatterson@sightlogix.com>
>>> ---
>>>
>>>   configs/rock2_defconfig | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>> Can you please give me an update on these patches? Did you discover
>> the root cause? What patches do you think need to be applied for this
>> release. I'd like to get a few more test reports too if possible.
>>
>> Regards,
>> Simon
>>
>>
>>
>>
>
>
Simon Glass Aug. 9, 2016, 2:35 p.m. UTC | #4
Hi Sandy,

On 8 August 2016 at 19:35, Sandy Patterson <apatterson@sightlogix.com> wrote:
> I also found that once the barrier stuff was in, the EFI_LOADER change was
> unnecessary.
>
> On Mon, Aug 8, 2016 at 8:50 PM, Ziyuan Xu <xzy.xu@rock-chips.com> wrote:
>>
>> Hi Simon,
>>
>> I think you can drop this patch due to it fixes by a78cd86 - ARM: Rework
>> and correct barrier which Tom had merge it into u-boot/master.

That's great, thanks for letting me know.

BTW for the mailing list can you please avoid top-posting?

Regards,
Simon

>>
>>
>> On 2016年08月09日 05:43, Simon Glass wrote:
>>>
>>> Hi Sandy,
>>>
>>> On 22 July 2016 at 08:40, Sandy Patterson <apatterson@sightlogix.com>
>>> wrote:
>>>>
>>>> The problem seems to be invalidate_icache_all() inside the runtime.
>>>> This patch just disables EFI_LOADER for rock2 board.
>>>>
>>>> Signed-off-by: Sandy Patterson <apatterson@sightlogix.com>
>>>> ---
>>>>
>>>>   configs/rock2_defconfig | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>
>>> Can you please give me an update on these patches? Did you discover
>>> the root cause? What patches do you think need to be applied for this
>>> release. I'd like to get a few more test reports too if possible.
>>>
>>> Regards,
>>> Simon
>>>
>>>
>>>
>>
>>
>
diff mbox

Patch

diff --git a/configs/rock2_defconfig b/configs/rock2_defconfig
index 3e16b80..3a06b7e 100644
--- a/configs/rock2_defconfig
+++ b/configs/rock2_defconfig
@@ -67,3 +67,4 @@  CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
+# CONFIG_EFI_LOADER is not set