From patchwork Sat Sep 18 22:45:39 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Koenig X-Patchwork-Id: 65139 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0117BB6EE9 for ; Sun, 19 Sep 2010 08:46:00 +1000 (EST) Received: (qmail 13251 invoked by alias); 18 Sep 2010 22:45:49 -0000 Received: (qmail 13230 invoked by uid 22791); 18 Sep 2010 22:45:48 -0000 X-SWARE-Spam-Status: No, hits=-0.1 required=5.0 tests=AWL, BAYES_20, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp5.netcologne.de (HELO smtp5.netcologne.de) (194.8.194.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Sep 2010 22:45:42 +0000 Received: from [192.168.0.196] (xdsl-84-44-143-109.netcologne.de [84.44.143.109]) by smtp5.netcologne.de (Postfix) with ESMTP id 6827A40CCAD; Sun, 19 Sep 2010 00:45:39 +0200 (CEST) Subject: Re: [patch, fortran] Make front end walker more complete From: Thomas Koenig To: Mikael Morin Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org, jakub@redhat.com In-Reply-To: <201009190018.16056.mikael.morin@sfr.fr> References: <1284752085.9243.100.camel@linux-fd1f.site> <201009190018.16056.mikael.morin@sfr.fr> Date: Sun, 19 Sep 2010 00:45:39 +0200 Message-ID: <1284849939.8401.25.camel@linux-fd1f.site> Mime-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi Mikael, > > 2010-09-17 Thomas Koenig > > > > * frontend-passes.c (gfc_expr_walker): Handle > > constructors and references. > There is still EXPR_SUBSTRING that can have a subreference, but it can be a > follow-up (obvious probably) patch. > Thus, OK. Committed as rev. 164403. You're right about EXPR_SUBSTRING, I have commited the following patch as obvious as rev. after regression-testing: Thanks a lot for the review, and for catching that case! Thomas Index: ChangeLog =================================================================== --- ChangeLog (Revision 164403) +++ ChangeLog (Arbeitskopie) @@ -1,5 +1,10 @@ -2010-09-17 Thomas Koenig +2010-09-19 Thomas Koenig + * frontend-passes.c (gfc_expr_walker): Also + handle EXPR_SUBSTRING. + +2010-09-19 Thomas Koenig + * frontend-passes.c (gfc_expr_walker): Handle constructors and references. Index: frontend-passes.c =================================================================== --- frontend-passes.c (Revision 164403) +++ frontend-passes.c (Arbeitskopie) @@ -365,6 +365,7 @@ /* Fall through to the variable case in order to walk the the reference. */ + case EXPR_SUBSTRING: case EXPR_VARIABLE: for (r = (*e)->ref; r; r = r->next) {