Patchwork [fortran] Make front end walker more complete

login
register
mail settings
Submitter Thomas Koenig
Date Sept. 18, 2010, 10:45 p.m.
Message ID <1284849939.8401.25.camel@linux-fd1f.site>
Download mbox | patch
Permalink /patch/65139/
State New
Headers show

Comments

Thomas Koenig - Sept. 18, 2010, 10:45 p.m.
Hi Mikael,



> > 2010-09-17  Thomas Koenig  <tkoenig@gcc.gnu.org>
> > 
> > 	* frontend-passes.c (gfc_expr_walker):  Handle
> > 	constructors and references.
> There is still EXPR_SUBSTRING that can have a subreference, but it can be a 
> follow-up (obvious probably) patch. 
> Thus, OK. 

Committed as rev. 164403.

You're right about EXPR_SUBSTRING, I have commited the following patch
as obvious as rev.    after regression-testing:


Thanks a lot for the review, and for catching that case!

	Thomas

Patch

Index: ChangeLog
===================================================================
--- ChangeLog   (Revision 164403)
+++ ChangeLog   (Arbeitskopie)
@@ -1,5 +1,10 @@ 
-2010-09-17  Thomas Koenig  <tkoenig@gcc.gnu.org>
+2010-09-19  Thomas Koenig  <tkoenig@gcc.gnu.org>

+       * frontend-passes.c (gfc_expr_walker):  Also
+       handle EXPR_SUBSTRING.
+
+2010-09-19  Thomas Koenig  <tkoenig@gcc.gnu.org>
+
        * frontend-passes.c (gfc_expr_walker):  Handle
        constructors and references.

Index: frontend-passes.c
===================================================================
--- frontend-passes.c   (Revision 164403)
+++ frontend-passes.c   (Arbeitskopie)
@@ -365,6 +365,7 @@ 
            /* Fall through to the variable case in order to walk the
               the reference.  */

+         case EXPR_SUBSTRING:
          case EXPR_VARIABLE:
            for (r = (*e)->ref; r; r = r->next)
              {