Patchwork usibfs: fix kconfig dependency warning

login
register
mail settings
Submitter Randy Dunlap
Date Sept. 18, 2010, 7:53 p.m.
Message ID <20100918125340.7a2cbb8b.randy.dunlap@oracle.com>
Download mbox | patch
Permalink /patch/65136/
State New
Headers show

Comments

Randy Dunlap - Sept. 18, 2010, 7:53 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>

Fix another kconfig dependency warning, this time in ubifs.

warning: (MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI && KALLSYMS && DEBUG_KERNEL || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT && DEBUG_KERNEL && STACKTRACE_SUPPORT && PROC_FS) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:      Artem Bityutskiy <dedekind1@gmail.com>
Cc:      Adrian Hunter <adrian.hunter@nokia.com>
Cc:      linux-mtd@lists.infradead.org
---
 fs/ubifs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Randy Dunlap - Sept. 18, 2010, 8 p.m.
On Sat, 18 Sep 2010 12:53:40 -0700 Randy Dunlap wrote:


sorry, subject should be "ubifs".

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Artem Bityutskiy - Sept. 20, 2010, 8:45 a.m.
On Sat, 2010-09-18 at 12:53 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix another kconfig dependency warning, this time in ubifs.
> 
> warning: (MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI && KALLSYMS && DEBUG_KERNEL || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT && DEBUG_KERNEL && STACKTRACE_SUPPORT && PROC_FS) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)

Pushed to the ubifs-2.6.git tree. This won't go to 2.6.36, though, I
think - not too important. But I have anything really important, I'll
merge this one as well, although for now I do not have such plans.

Thanks!
Jon Povey - Sept. 21, 2010, 4:23 a.m.
linux-mtd-bounces@lists.infradead.org wrote:
> Pushed to the ubifs-2.6.git tree.

If the typo "usibfs" in the subject was in the patch you might want to
fix it if there's still time.

--
Jon Povey
jon.povey@racelogic.co.uk

Racelogic is a limited company registered in England. Registered number 2743719 .
Registered Office Unit 10, Swan Business Centre, Osier Way, Buckingham, Bucks, MK18 1TB .

The information contained in this electronic mail transmission is intended by Racelogic Ltd for the use of the named individual or entity to which it is directed and may contain information that is confidential or privileged. If you have received this electronic mail transmission in error, please delete it from your system without copying or forwarding it, and notify the sender of the error by reply email so that the sender's address records can be corrected. The views expressed by the sender of this communication do not necessarily represent those of Racelogic Ltd. Please note that Racelogic reserves the right to monitor e-mail communications passing through its network
Artem Bityutskiy - Sept. 21, 2010, 7:19 a.m.
On Tue, 2010-09-21 at 05:23 +0100, Jon Povey wrote:
> linux-mtd-bounces@lists.infradead.org wrote:
> > Pushed to the ubifs-2.6.git tree.
> 
> If the typo "usibfs" in the subject was in the patch you might want to
> fix it if there's still time.

I fixed it up. I never apply patches without looking at the subject
line, and I always use git am -i, which means edit the commit message
before applying.

So it is ok, thanks for heads up though!

Patch

--- linux-next-20100917.orig/fs/ubifs/Kconfig
+++ linux-next-20100917/fs/ubifs/Kconfig
@@ -47,7 +47,7 @@  config UBIFS_FS_DEBUG
 	bool "Enable debugging"
 	depends on UBIFS_FS
 	select DEBUG_FS
-	select KALLSYMS_ALL
+	select KALLSYMS_ALL if DEBUG_KERNEL && KALLSYMS
 	help
 	  This option enables UBIFS debugging.