From patchwork Sat Sep 18 15:32:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 65129 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id F0960B70B8 for ; Sun, 19 Sep 2010 01:32:26 +1000 (EST) Received: (qmail 19616 invoked by alias); 18 Sep 2010 15:32:23 -0000 Received: (qmail 19565 invoked by uid 22791); 18 Sep 2010 15:32:21 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2bthomr07.btconnect.com (HELO mail.btconnect.com) (213.123.20.125) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Sep 2010 15:32:12 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2bthomr07.btconnect.com with ESMTP id AFV78332; Sat, 18 Sep 2010 16:32:07 +0100 (BST) Cc: GCC Patches Message-Id: From: IainS To: Paolo Bonzini In-Reply-To: <4C90EBC8.2040507@gnu.org> Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [Patch libgcc build] cater for static archives as 'extra parts' Date: Sat, 18 Sep 2010 16:32:06 +0100 References: <4C90EBC8.2040507@gnu.org> X-Mirapoint-IP-Reputation: reputation=Fair-1, source=Queried, refid=tid=0001.0A0B0302.4C94DB76.0196, actions=TAG X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0204.4C94DB79.0297, ss=1, fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=single engine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 15 Sep 2010, at 16:52, Paolo Bonzini wrote: > On 09/15/2010 05:51 PM, IainS wrote: >> Index: libgcc/Makefile.in >> =================================================================== >> --- libgcc/Makefile.in (revision 164304) >> +++ libgcc/Makefile.in (working copy) >> @@ -870,6 +870,9 @@ endif >> for file in $$parts; do \ >> rm -f $(gcc_objdir)$(MULTISUBDIR)/$$file; \ >> $(INSTALL_DATA) $$file $(gcc_objdir)$(MULTISUBDIR)/; \ >> + if [ $${file##*.} = "a" ] ; then \ >> + $(RANLIB) $(gcc_objdir)$(MULTISUBDIR)/$$file; \ >> + fi; \ > > Please use "case", ${file##*.} is a bashism. Is this OK? Iain Index: libgcc/Makefile.in =================================================================== --- libgcc/Makefile.in (revision 164393) +++ libgcc/Makefile.in (working copy) @@ -870,6 +870,10 @@ endif for file in $$parts; do \ rm -f $(gcc_objdir)$(MULTISUBDIR)/$$file; \ $(INSTALL_DATA) $$file $(gcc_objdir)$(MULTISUBDIR)/; \ + case $$file in \ + *.a) \ + $(RANLIB) $(gcc_objdir)$(MULTISUBDIR)/$$file ;; \ + esac; \ done # Build extra startfiles in the gcc directory, for unconverted @@ -903,6 +907,10 @@ gcc-extra-parts: for file in $$parts; do \ rm -f $(gcc_objdir)$(MULTISUBDIR)/$$file; \ $(INSTALL_DATA) $$file $(gcc_objdir)$(MULTISUBDIR)/; \ + case $$file in \ + *.a) \ + $(RANLIB) $(gcc_objdir)$(MULTISUBDIR)/$$file ;; \ + esac; \ done all: $(extra-parts) @@ -958,6 +966,10 @@ install-leaf: $(install-shared) $(install-libunwin for file in $$parts; do \ rm -f $(DESTDIR)$(inst_libdir)/$$file; \ $(INSTALL_DATA) $$file $(DESTDIR)$(inst_libdir)/; \ + case $$file in \ + *.a) \ + $(RANLIB) $(gcc_objdir)$(MULTISUBDIR)/$$file ;; \ + esac; \ done install: install-leaf