From patchwork Fri Sep 17 19:15:43 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Do not print warning messages when there are no occurences. Date: Fri, 17 Sep 2010 09:15:43 -0000 From: Sebastian Pop X-Patchwork-Id: 65100 Message-Id: <1284750943-31569-1-git-send-email-sebpop@gmail.com> To: gcc-patches@gcc.gnu.org Cc: Sebastian Pop The patch checker used to print warning messages "Lines should not exceed 80 characters." even when there were no such lines in the patch. With this change, the warning message is printed only when there are such occurrences. Committed to trunk. 2010-07-02 Sebastian Pop * check_GNU_style.sh: Do not print warning messages when there are no occurences. --- contrib/ChangeLog | 5 +++++ contrib/check_GNU_style.sh | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/contrib/ChangeLog b/contrib/ChangeLog index 5175d51..a6b6e11 100644 --- a/contrib/ChangeLog +++ b/contrib/ChangeLog @@ -1,3 +1,8 @@ +2010-07-02 Sebastian Pop + + * check_GNU_style.sh: Do not print warning messages when there are + no occurences. + 2010-07-08 Eric Botcazou * make_sunver.pl: Remove extra whitespace in regexp. diff --git a/contrib/check_GNU_style.sh b/contrib/check_GNU_style.sh index 6396417..8fb579f 100755 --- a/contrib/check_GNU_style.sh +++ b/contrib/check_GNU_style.sh @@ -84,8 +84,11 @@ col (){ | grep -v ':+++' \ | cut -f 2 -d '+' \ | awk '{ if (length ($0) > 80) print $0 }' \ - > $tmp && printf "\n$msg\n" - cat $tmp + > $tmp + if [ -s $tmp ]; then + printf "\n$msg\n" + cat $tmp + fi } col 'Lines should not exceed 80 characters.' $*