| Message ID | 1468994313-13538-8-git-send-email-andrew@aj.id.au |
|---|---|
| State | New |
| Headers | show |
On Wed, Jul 20, 2016 at 03:28:28PM +0930, Andrew Jeffery wrote: > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt > new file mode 100644 > index 000000000000..4df798799101 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt > @@ -0,0 +1,16 @@ > +The Aspeed System Control Unit manages the global behaviour of the SoC, > +configuring elements such as clocks, pinmux, and reset. > + > +Required properties: > +- compatible: One of: > + "aspeed,g4-scu", "syscon", "simple-mfd" > + "aspeed,g5-scu", "syscon", "simple-mfd" These (and the pinctrl probably) really need SoC specific compatible strings. You can keep these as fallbacks though. These are the parts of SoCs that really vary chip to chip. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2016-07-20 at 14:09 -0500, Rob Herring wrote: > On Wed, Jul 20, 2016 at 03:28:28PM +0930, Andrew Jeffery wrote: > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > --- > > Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt > > new file mode 100644 > > index 000000000000..4df798799101 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt > > @@ -0,0 +1,16 @@ > > +The Aspeed System Control Unit manages the global behaviour of the SoC, > > +configuring elements such as clocks, pinmux, and reset. > > + > > +Required properties: > > +- compatible: One of: > > + "aspeed,g4-scu", "syscon", "simple-mfd" > > + "aspeed,g5-scu", "syscon", "simple-mfd" > These (and the pinctrl probably) really need SoC specific compatible > strings. You can keep these as fallbacks though. These are the parts of > SoCs that really vary chip to chip. I'll add the SoC-specific compatible strings. Cheers, Andrew
diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt new file mode 100644 index 000000000000..4df798799101 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt @@ -0,0 +1,16 @@ +The Aspeed System Control Unit manages the global behaviour of the SoC, +configuring elements such as clocks, pinmux, and reset. + +Required properties: +- compatible: One of: + "aspeed,g4-scu", "syscon", "simple-mfd" + "aspeed,g5-scu", "syscon", "simple-mfd" + +- reg: contains the offset and length of the SCU memory region + +Example: + +syscon: syscon@1e6e2000 { + compatible = "aspeed,g4-scu", "syscon", "simple-mfd"; + reg = <0x1e6e2000 0x1a8>; +};
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt