diff mbox

[PULL,v2,02/55] tests/prom-env-test: increase the test timeout

Message ID 20160719175023.GA32607@redhat.com
State New
Headers show

Commit Message

Michael S. Tsirkin July 19, 2016, 5:50 p.m. UTC
From: Marcel Apfelbaum <marcel@redhat.com>

On a slower machine the test can take more than 30 seconds.
Increase the timeout to 100 seconds.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 tests/prom-env-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Gibson July 20, 2016, 12:10 a.m. UTC | #1
On Tue, Jul 19, 2016 at 08:50:23PM +0300, Michael S. Tsirkin wrote:
> From: Marcel Apfelbaum <marcel@redhat.com>
> 
> On a slower machine the test can take more than 30 seconds.
> Increase the timeout to 100 seconds.
> 
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  tests/prom-env-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c
> index 6df57d2..7a62857 100644
> --- a/tests/prom-env-test.c
> +++ b/tests/prom-env-test.c
> @@ -30,7 +30,7 @@ static void check_guest_memory(void)
>      int i;
>  
>      /* Poll until code has run and modified memory. Wait at most 30 seconds */

Changing the comment to match would have been nice.

> -    for (i = 0; i < 3000; ++i) {
> +    for (i = 0; i < 10000; ++i) {
>          signature = readl(ADDRESS);
>          if (signature == MAGIC) {
>              break;
diff mbox

Patch

diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c
index 6df57d2..7a62857 100644
--- a/tests/prom-env-test.c
+++ b/tests/prom-env-test.c
@@ -30,7 +30,7 @@  static void check_guest_memory(void)
     int i;
 
     /* Poll until code has run and modified memory. Wait at most 30 seconds */
-    for (i = 0; i < 3000; ++i) {
+    for (i = 0; i < 10000; ++i) {
         signature = readl(ADDRESS);
         if (signature == MAGIC) {
             break;