| Message ID | 1468861517-2508-11-git-send-email-nikunj@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
On 07/18/2016 10:35 PM, Nikunj A Dadhania wrote: > + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x3); > + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1); > + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x1); > + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 1, l2); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 1); > + tcg_gen_br(out); > + gen_set_label(l2); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], -1); > + tcg_gen_br(out); > + gen_set_label(l1); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 0); > + gen_set_label(out); Without branches: tcg_gen_setcondi_i32(TCG_COND_GEU, t0, cpu_crf[crf], 4); tcg_gen_movi_i32(t8, 8); tcg_gen_movi_i32(tm1, -1); tcg_gen_movcond_i32(TCG_COND_GEU, t0, cpu_crf[crf], t8, tm1, t0); tcg_gen_ext_i32_tl(cpu_gpr[rD(ctx->opcode)], t0); r~
On Mon, Jul 18, 2016 at 10:35:14PM +0530, Nikunj A Dadhania wrote: > From: Vivek Andrew Sha <vivekandrewsha@gmail.com> > > Returns: > -1 if bit 0 of CR field is set > 0 if bit 1 of CR field is set > 1 otherwise. Um.. that description is pretty inadequate. Retuns where? Which CR field? > Signed-off-by: Vivek Andrew Sha <vivekandrewsha@gmail.com> > [ reworded commit, used 32bit ops as crf is 32bits ] > Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com> > --- > target-ppc/translate.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 8f7ff49..9464942 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -4879,6 +4879,35 @@ static void gen_mtspr(DisasContext *ctx) > } > } > > +#if defined(TARGET_PPC64) > +/* setb */ > +static void gen_setb(DisasContext *ctx) > +{ > + TCGLabel *l1 = gen_new_label(); > + TCGLabel *l2 = gen_new_label(); > + TCGLabel *out = gen_new_label(); > + TCGv_i32 t0 = tcg_temp_local_new_i32(); > + TCGv_i64 ret = tcg_temp_local_new_i64(); > + int crf = crfS(ctx->opcode); > + > + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x3); > + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1); > + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x1); > + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 1, l2); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 1); > + tcg_gen_br(out); > + gen_set_label(l2); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], -1); > + tcg_gen_br(out); > + gen_set_label(l1); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 0); > + gen_set_label(out); > + > + tcg_temp_free_i32(t0); > + tcg_temp_free_i64(ret); > +} > +#endif > + > /*** Cache management ***/ > > /* dcbf */ > @@ -10195,6 +10224,7 @@ GEN_HANDLER(mftb, 0x1F, 0x13, 0x0B, 0x00000001, PPC_MFTB), > GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00000801, PPC_MISC), > #if defined(TARGET_PPC64) > GEN_HANDLER(mtmsrd, 0x1F, 0x12, 0x05, 0x001EF801, PPC_64B), > +GEN_HANDLER_E(setb, 0x1F, 0x00, 0x04, 0x0003F801, PPC_NONE, PPC2_ISA300), > #endif > GEN_HANDLER(mtmsr, 0x1F, 0x12, 0x04, 0x001EF801, PPC_MISC), > GEN_HANDLER(mtspr, 0x1F, 0x13, 0x0E, 0x00000000, PPC_MISC),
David Gibson <david@gibson.dropbear.id.au> writes: > [ Unknown signature status ] > On Mon, Jul 18, 2016 at 10:35:14PM +0530, Nikunj A Dadhania wrote: >> From: Vivek Andrew Sha <vivekandrewsha@gmail.com> >> >> Returns: >> -1 if bit 0 of CR field is set >> 0 if bit 1 of CR field is set >> 1 otherwise. > > Um.. that description is pretty inadequate. Retuns where? Which CR > field? I will update, its encoded in the opcode. Regards Nikunj
diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 8f7ff49..9464942 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -4879,6 +4879,35 @@ static void gen_mtspr(DisasContext *ctx) } } +#if defined(TARGET_PPC64) +/* setb */ +static void gen_setb(DisasContext *ctx) +{ + TCGLabel *l1 = gen_new_label(); + TCGLabel *l2 = gen_new_label(); + TCGLabel *out = gen_new_label(); + TCGv_i32 t0 = tcg_temp_local_new_i32(); + TCGv_i64 ret = tcg_temp_local_new_i64(); + int crf = crfS(ctx->opcode); + + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x3); + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1); + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x1); + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 1, l2); + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 1); + tcg_gen_br(out); + gen_set_label(l2); + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], -1); + tcg_gen_br(out); + gen_set_label(l1); + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 0); + gen_set_label(out); + + tcg_temp_free_i32(t0); + tcg_temp_free_i64(ret); +} +#endif + /*** Cache management ***/ /* dcbf */ @@ -10195,6 +10224,7 @@ GEN_HANDLER(mftb, 0x1F, 0x13, 0x0B, 0x00000001, PPC_MFTB), GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00000801, PPC_MISC), #if defined(TARGET_PPC64) GEN_HANDLER(mtmsrd, 0x1F, 0x12, 0x05, 0x001EF801, PPC_64B), +GEN_HANDLER_E(setb, 0x1F, 0x00, 0x04, 0x0003F801, PPC_NONE, PPC2_ISA300), #endif GEN_HANDLER(mtmsr, 0x1F, 0x12, 0x04, 0x001EF801, PPC_MISC), GEN_HANDLER(mtspr, 0x1F, 0x13, 0x0E, 0x00000000, PPC_MISC),